Uh oh!
There was an error while loading. Please reload this page.
Document tintColor option for ActionSheetIOS - #36
Conversation
also: - fixed the `showActionSheetWithOptions` example This option was added in react/react-native#4590 FYI, this is not even documented in the comments https://github.com/facebook/react-native/blob/master/Libraries/ActionSheetIOS/ActionSheetIOS.js#L28 Are the docs generated from the code? Should I update that instead?
facebook-github-bot
commented
Dec 7, 2017
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Dec 7, 2017
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
hramos
commented
Dec 7, 2017
The docs were initially generated from code, but going forward they will not be synced. Feel free to add any necessary comments back into the JS file. The idea here is to have the full API reference documented on the website, while only having minimal comments for each method in the source code. It will take a while to update every source file to match this style but you can see an example of what we're going for here: |
hramos
commented
Dec 7, 2017
Can you make this change to the file in |
gianpaj
commented
Dec 11, 2017
Thanks for fixing the conflicts. I didn't have time and now I know how I should have done it as well :) |
also:
showActionSheetWithOptionsexampleThis option was added in react/react-native#4590
FYI, this is not even documented in the comments
https://github.com/facebook/react-native/blob/master/Libraries/ActionSheetIOS/ActionSheetIOS.js#L28
Are the docs generated from the code? Should I update that instead?