Uh oh!
There was an error while loading. Please reload this page.
docs: iOS backwards compatibility update - #3775
Merged
cipolleschi merged 4 commits intoJul 21, 2023
Merged
Conversation
Ensure backwards-compat docs refer to all necessary code changes. reactwg/react-native-new-architecture#8 (comment)
facebook-github-bot
commented
Jun 27, 2023
Hi @connorpmullins! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
connorpmullins
commented
Jun 27, 2023
ContributorAuthor
I have signed the CLA |
cipolleschi
requested changes
Jun 30, 2023
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Hi @connorpmullins, thank you so much for starting this. I left a suggestion to update the wording as I am a bit scared that the word "replicate" could drive people away. I also added a very brief explanation of why this is needed.
How do you feel about this change?
Uh oh!
There was an error while loading. Please reload this page.
…ents.md Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
connorpmullins
commented
Jul 10, 2023
ContributorAuthor
@cipolleschi - sorry for the delay - just back from vacation. I like the suggestion 👍 |
cipolleschi
commented
Jul 20, 2023
Contributor
Hi @connorpmullins, now it was my turn to be on vacation! You can either fix it manually or run yarn prettier locally! :D |
sunnylqm added a commit
to reactnativecn/react-native-website
that referenced
this pull request
Aug 5, 2023
* Update Debugging docs to no longer recommend Remote debugging (react#3702) Co-authored-by: Alex Hunt <hello@alexhunt.io> * Bump fast-xml-parser from 4.2.4 to 4.2.5 (react#3777) Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.2.4 to 4.2.5. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v4.2.4...v4.2.5) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Upgrade got dependency (react#3776) * feature: Move to GA4 (UA being reprecated in June) Google Analytics is deprecating the older clients. This is the first step to enable to newer client. This should be followed with a step to remove the old client once we know data is flowing. * Upgrade got dependency Resolves dependabot alerts #26 * Use `https` links over `http` (react#3761) * [docs] Update/simplify info around Metro for env setup (react#3673) * [docs] Add Metro guide, update Metro config references (react#3772) * [docs] Remove static config note in Metro guide, adjust formatting (react#3782) * Improving Grammar and Clarity.md (react#3783) Improving Grammar and Clarity in React Native's Performance Description * Fix docs for onResponderGrant (react#3785) * react-native-gradle-plugin renamed to @react-native/gradle-plugin (react#3786) * Update _integration-with-existing-apps-kotlin.md * Update _integration-with-existing-apps-kotlin.md * Update _integration-with-existing-apps-java.md * Update _integration-with-existing-apps-java.md * Update _integration-with-existing-apps-kotlin.md * Update how-to-build-from-source for 0.72+ (react#3659) * Clarify documentation for turbomodules (react#3787) * Clarify documentation for turbomodules `codegenConfig` is stated in text that it's an array, but in code example it's an object. Either the text or the code example should change. * Fix linting issue * Update the PR to reflect knowledge that the code sample is correct but documentation wrong * Update FlatList Optimization Guide for FCs (react#3700) * Update FlatList Optimization Guide for FCs * fix lint * Update docs/optimizing-flatlist-configuration.md --------- Co-authored-by: Егорик <86266852+Huinko@users.noreply.github.com> Co-authored-by: Nick Gerleman <nick@nickgerleman.com> * [docs] Add guidance on repo build scripts (react#3788) * [docs] add Chain React 2023 playlist link on staying-updated (react#3790) * Bump semver from 5.7.1 to 5.7.2 (react#3791) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docusaurus v2.4.1 (react#3778) * Bump word-wrap from 1.2.3 to 1.2.4 (react#3794) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: iOS backwards compatibility update (react#3775) * Update backward-compatibility-fabric-components.md Ensure backwards-compat docs refer to all necessary code changes. reactwg/react-native-new-architecture#8 (comment) * Update docs/the-new-architecture/backward-compatibility-fabric-components.md Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com> * trim whitespace and fix typo --------- Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com> * [website] swizzle DocVersionBanner, tweak wording (react#3800) * tweak: improve wordiness on docs about bumping monorepo packages (react#3805) * Fix typo in architecture-glossary.md (react#3806) * docs: change js to tsx (react#3808) * Update website to use JDK 17 (react#3812) LGTM. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com> Co-authored-by: Alex Hunt <hello@alexhunt.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Blake Friedman <blakef@meta.com> Co-authored-by: Pranav Yadav <Pranavyadav3912@gmail.com> Co-authored-by: Waseem Kurne <55435990+waseemk7@users.noreply.github.com> Co-authored-by: Pieter De Baets <pieterdb@meta.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Stefan Wallin <github@stefan-wallin.se> Co-authored-by: Егорик <86266852+Azelisi@users.noreply.github.com> Co-authored-by: Егорик <86266852+Huinko@users.noreply.github.com> Co-authored-by: Nick Gerleman <nick@nickgerleman.com> Co-authored-by: David Leuliette <dleuliette@gmail.com> Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com> Co-authored-by: Connor Mullins <connorpmullins@gmail.com> Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: Lorenzo Sciandra <lsciandra@microsoft.com> Co-authored-by: Stanley Ugwu <stanleyugwu2018@gmail.com> Co-authored-by: kong <duguyihou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The iOS section of the Fabric Component Backwards Compatibility docs explicitly mentions the need to update two of the three documents created in the Fabric Component iOS Native Code section.
As someone without experience writing native code, it was unclear that it is necessary to update all three documents. This PR updates the documentation to clarify that point and links back to the relevant section of the Legacy Native Component docs.
Link to the discussion this PR stems from
Screenshot