Skip to content

Update testing instructions for the script that downloads artifacts from CircleCI - #3795

Merged
cipolleschi merged 3 commits into
mainfrom
cipolleschi/improved-release-testing
Aug 8, 2023
Merged

Update testing instructions for the script that downloads artifacts from CircleCI#3795
cipolleschi merged 3 commits into
mainfrom
cipolleschi/improved-release-testing

Conversation

@cipolleschi

Copy link
Copy Markdown
Contributor

This PR adds further instructions on how to test the release flow before a Release, describing how to leverage the new -c parameter.

@kelsetkelset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to wait to backport this to 72 and 71 before merging, aside from that LGTM

@netlify

netlifyBot commented Jul 21, 2023

Copy link
Copy Markdown

Deploy Preview for react-native ready!

NameLink
🔨 Latest commit86ae259
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/64d243339847090008df277d
😎 Deploy Previewhttps://deploy-preview-3795--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment threadwebsite/contributing/release-testing.md Outdated
Co-authored-by: Nicola Corti <corti.nico@gmail.com>

@fortmarekfortmarek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can't wait to use the script 😍

Comment threadwebsite/contributing/release-testing.md Outdated
Comment threadwebsite/contributing/release-testing.md
Co-authored-by: Marek Fořt <marekfort@me.com>
@cipolleschi
cipolleschi merged commit a2d6242 into mainAug 8, 2023
@cipolleschi
cipolleschi deleted the cipolleschi/improved-release-testing branch August 8, 2023 13:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cipolleschi@cortinico@fortmarek@kelset@facebook-github-bot