Skip to content

wip - #4293

Closed
rickhanlonii wants to merge 14 commits into
mainfrom
the-new-architecture
Closed

wip#4293
rickhanlonii wants to merge 14 commits into
mainfrom
the-new-architecture

Conversation

@rickhanlonii

@rickhanloniirickhanlonii commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@rickhanlonii
rickhanlonii marked this pull request as draft October 23, 2024 01:02
rickhanlonii
rickhanlonii commented Oct 23, 2024
View reviewed changes
Comment threadwebsite/docusaurus.config.js
locales: ['en'],
},
onBrokenLinks: 'throw',
onBrokenLinks: 'log',

@rickhanloniirickhanloniiOct 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove this after fixing all the links

@netlify

netlifyBot commented Oct 23, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for react-native ready!

NameLink
🔨 Latest commit7e94980
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/6719314bb6381d0008d2b629
😎 Deploy Previewhttps://deploy-preview-4293--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

javache
javache reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
rickhanloniiand others added 2 commits October 23, 2024 01:04
@rickhanlonii@lunaleaps
Apply suggestions from code review
9d1722e
Co-authored-by: Luna <lunaleaps@gmail.com>
@rickhanlonii
fixes
963c928
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
lunaleaps
lunaleaps reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
yungsters
yungsters reviewed Oct 23, 2024
View reviewed changes

@yungstersyungsters left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting minor nits for the introduction of the blog post.

Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
yungsters
yungsters reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
yungsters
yungsters reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
@rickhanlonii@yungsters
Apply suggestions from code review
13f293c
Co-authored-by: Timothy Yung <yungsters@meta.com>
yungsters
yungsters reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
yungsters
yungsters reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
javache
javache reviewed Oct 23, 2024
View reviewed changes
Comment threadwebsite/blog/2024-10-23-The-New-Architecture-is-Here.md Outdated
@rickhanlonii

rickhanlonii commented Oct 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Merged into #4279

@yungsters@javache I'll incorporate your feedback there!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javachejavachejavache left review comments
+2 more reviewers
@yungstersyungstersyungsters left review comments
@lunaleapslunaleapslunaleaps left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedp: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rickhanlonii@javache@yungsters@lunaleaps@facebook-github-bot