Skip to content

Migrate codebase to TypeScript and update configurations - #4381

Merged
Abbondanzo merged 18 commits into
react:mainfrom
clicktodev:typescript-support
Dec 4, 2024
Merged

Migrate codebase to TypeScript and update configurations#4381
Abbondanzo merged 18 commits into
react:mainfrom
clicktodev:typescript-support

Conversation

@clicktodev

@clicktodevclicktodev commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Refactor the codebase by converting JavaScript files to TypeScript, enhancing type safety and updating related configurations accordingly.

closes#4380

@netlify

netlifyBot commented Dec 2, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for react-native ready!

NameLink
🔨 Latest commited63d5b
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/67502e0e52ef390008dfc0f0
😎 Deploy Previewhttps://deploy-preview-4381--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@clicktodevclicktodev mentioned this pull request Dec 2, 2024
Merged
Abbondanzo
Abbondanzo requested changes Dec 3, 2024
View reviewed changes

@AbbondanzoAbbondanzo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes but overall looks great!

Comment threadwebsite/src/pages/showcase.tsx Outdated
Comment threadwebsite/src/pages/showcase.tsx Outdated
Comment threadwebsite/src/pages/showcase.tsx Outdated
Comment threadwebsite/src/theme/BlogSidebar/Desktop/index.d.ts
@clicktodev

clicktodev commented Dec 3, 2024

Copy link
Copy Markdown
ContributorAuthor

All good 🚀

Simek
Simek reviewed Dec 3, 2024
View reviewed changes
Comment threadwebsite/package.json Outdated
Simek
Simek reviewed Dec 3, 2024
View reviewed changes
Comment threadwebsite/src/pages/Home/components/ThemeImage/index.tsx Outdated
Simek
Simek reviewed Dec 3, 2024
View reviewed changes
Comment threadwebsite/src/theme/MDXComponents/InlineCode.tsx Outdated
Simek
Simek requested changes Dec 3, 2024
View reviewed changes

@SimekSimek left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! 👍 Left few suggestions above.

@clicktodev
clicktodev requested a review from SimekDecember 3, 2024 12:11
Simek
Simek reviewed Dec 3, 2024
View reviewed changes
Comment threadwebsite/src/pages/showcase.tsx Outdated
Simek
Simek reviewed Dec 3, 2024
View reviewed changes
Comment threadwebsite/core/DocsRating.tsx Outdated
@clicktodev
clicktodev requested a review from SimekDecember 3, 2024 12:33
@Simek

Simek commented Dec 3, 2024

Copy link
Copy Markdown
Collaborator

I have some yarn.lock changes generated when running branch code locally. Can you make sure that lock is up to date?

When yarn is run in monorepo root we also run lock deduplication automatically after that, so make sure that you run it from there. There is no need to address it now by hooking it also at website level, since with yarn upgrade it will be redundant anyway.

@clicktodev

clicktodev commented Dec 3, 2024

Copy link
Copy Markdown
ContributorAuthor

lockfile is now uptodate

Simek
Simek approved these changes Dec 3, 2024
View reviewed changes

@SimekSimek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick updates! 🙏

Tested the changes locally, switching to TypeScript is a nice codebase and DX improvement, LGTM! 👍

@clicktodev

clicktodev commented Dec 3, 2024

Copy link
Copy Markdown
ContributorAuthor

Awesome let’s get this bad boy merged 🚀

@clicktodevclicktodev changed the title Migrate JavaScript files to TypeScript and update configurationsMigrate codebase to TypeScript and update configurationsDec 3, 2024
Simek
Simek reviewed Dec 3, 2024
View reviewed changes
Comment threadwebsite/package.json Outdated
Simek
Simek reviewed Dec 3, 2024
View reviewed changes
Comment threadwebsite/package.json Outdated
@clicktodev
clicktodev requested a review from SimekDecember 3, 2024 15:24
Abbondanzo
Abbondanzo reviewed Dec 3, 2024
View reviewed changes
Comment threadwebsite/package.json Outdated
Comment threadwebsite/package.json Outdated
Comment threadwebsite/package.json Outdated
Abbondanzo
Abbondanzo reviewed Dec 3, 2024
View reviewed changes
Comment threadplugins/remark-snackplayer/package.json Outdated
Comment threadplugins/remark-lint-no-dead-urls/package.json Outdated
@Abbondanzo
Abbondanzo merged commit f007b3f into react:mainDec 4, 2024
@clicktodev
clicktodev deleted the typescript-support branch December 4, 2024 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimekSimekSimek approved these changes
@AbbondanzoAbbondanzoAbbondanzo approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

codebase lacks type safety

4 participants

@clicktodev@Simek@Abbondanzo@facebook-github-bot