Skip to content

add definition and example of how flexbox works - #947

Merged
cpojer merged 17 commits into
react:masterfrom
ecreeth:patch-1
Jun 12, 2019
Merged

add definition and example of how flexbox works#947
cpojer merged 17 commits into
react:masterfrom
ecreeth:patch-1

Conversation

@ecreeth

@ecreethecreeth commented May 21, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@react-native-bot

react-native-bot commented May 21, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit 1eb1994

https://deploy-preview-947--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to Contribute • Documentation Sources

@ecreethecreeth mentioned this pull request May 24, 2019
Closed
82 tasks
rickhanlonii
rickhanlonii requested changes May 31, 2019
View reviewed changes

@rickhanloniirickhanlonii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is great, thank you so much for putting this together!

I left some comments to review! The important changes are to the update the default flexDirection, removing duplicate content, and addressing the image sources in a better way 👍

Comment threaddocs/flexbox.md Outdated
Comment threaddocs/flexbox.md Outdated
Comment threaddocs/flexbox.md Outdated
Comment threaddocs/flexbox.md Outdated
Comment threaddocs/flexbox.md Outdated
Comment threaddocs/flexbox.md Outdated
Comment threaddocs/flexbox.md Outdated
Comment threaddocs/flexbox.md Outdated
Comment threaddocs/flexbox.md
Comment threaddocs/flexbox.md Outdated
cpojer
cpojer approved these changes Jun 12, 2019
View reviewed changes

@cpojercpojer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely fantastic. Thank you so much!

@cpojer
cpojer merged commit 660aed0 into react:masterJun 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii requested changes
+1 more reviewer
@cpojercpojercpojer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ecreeth@react-native-bot@cpojer@rickhanlonii