[Packager] require('react-native') must be assigned to React

[alinz]

By accident I have assigned require('react-native') to a variable other than React and It failed to execute. hmmm...

This code works fine

var React = require('react-native');

var {
 Component,
 View
} = React;

class MyApp extends Component {
 render() {
 return (
 <View></View>
 );
 }
}

module.exports = MyApp;

By this one doesn't

var Test = require('react-native');

var {
 Component,
 View
} = Test;

class MyApp extends Component {
 render() {
 return (
 <View></View>
 );
 }
}

module.exports = MyApp;

Here's what I got as an error:

[jtremback]

👍

[alinz]

After some digging I found that JSX transformer is the root cause.

Here's an example:

var Test = require('react-native');
...

render() {
 return (
 <View></View>
 );
}

is compiles into

return (
 React.createElement(View, null)
);

even though I required react-native to Test, JSX compiler doesn't really care and uses React object to create the View element.

[brentvatne]

What use case do you have for using a name other than React? While this isn't ideal I don't think it is really a big issue either 😄 cc. @frantic.

@alinz - If you want to look into it and submit a PR that would be great.

[alinz]

@brentvatne I don't have any! I wish I had one! ;)
I don't know whether this PR would be beneficial for anyone, but challenge accepted! 👍

[sophiebits]

We don't intend to support this in the JSX transformer, sorry. We require that you have React in scope.