OP-SQLite cannot build with 0.74RC and bridgeless

[ospfranco]

Description

Hi, I'm trying to test the library against the latest RC and also trying to get bridgeless to work. So far I'm facing two issues with the included example app in my library repo.

iOS:

It seems the codegen script is expecting the src files to be in node_modules, but the builder-bob template links the dependency directly via react-native.config.js:

// react-native.config.js
const path = require('path');
const pak = require('../package.json');

module.exports = {
 dependencies: {
 [pak.name]: {
 root: path.join(__dirname, '..'),
 },
 },
};

And I get the following error when trying to install the pods:

Android

After turning on all the flags (and bumping the minSDK to 23) I get a compilation error but no output to what is wrong:

Steps to reproduce

If you want to take a look yourself here is the branch. Just install deps via yarn and then try to run the example app: cd example && yarn android or the equivalent iOS commands.

React Native Version

0.74.0-rc.0

Affected Platforms

Build - MacOS

Areas

Bridgeless - The New Initialization Flow

Output of npx react-native info

System:
 OS: macOS 14.3.1
 CPU: (11) arm64 Apple M3 Pro
 Memory: 2.49 GB / 36.00 GB
 Shell:
 version: "5.9"
 path: /bin/zsh
Binaries:
 Node:
 version: 18.19.0
 path: ~/.nvm/versions/node/v18.19.0/bin/node
 Yarn:
 version: 4.0.2
 path: ~/.nvm/versions/node/v18.19.0/bin/yarn
 npm:
 version: 10.2.3
 path: ~/.nvm/versions/node/v18.19.0/bin/npm
 Watchman: Not Found
Managers:
 CocoaPods:
 version: 1.14.0
 path: /Users/osp/.rbenv/shims/pod
SDKs:
 iOS SDK:
 Platforms:
 - DriverKit 23.2
 - iOS 17.2
 - macOS 14.2
 - tvOS 17.2
 - visionOS 1.0
 - watchOS 10.2
 Android SDK:
 Android NDK: 26.0.10792818
IDEs:
 Android Studio: 2023.1 AI-231.9392.1.2311.11330709
 Xcode:
 version: 15.2/15C500b
 path: /usr/bin/xcodebuild
Languages:
 Java:
 version: 17.0.10
 path: /usr/bin/javac
 Ruby:
 version: 3.3.0
 path: /Users/osp/.rbenv/shims/ruby
npmPackages:
 "@react-native-community/cli": Not Found
 react:
 installed: 18.2.0
 wanted: 18.2.0
 react-native:
 installed: 0.74.0-rc.0
 wanted: ^0.74.0-rc.0
 react-native-macos: Not Found
npmGlobalPackages:
 "*react-native*": Not Found
Android:
 hermesEnabled: true
 newArchEnabled: true
iOS:
 hermesEnabled: true
 newArchEnabled: true

### Stacktrace or Logs

```text
Pasted above

Reproducer

https://github.com/OP-Engineering/op-sqlite/tree/bridgeless

Screenshots and Videos

No response

[github-actions]

⚠️	Missing Reproducible Example
ℹ️	We could not detect a reproducible example in your issue report. Please provide either: If your bug is UI related: a Snack If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

[cipolleschi]

Hi @ospfranco, thanks for the issue.

For Android, we are aware that codegen and autolinking are not working with the RC.0 as we needed a commit that landed right after the branch cut. It should be solved in RC1

For iOS, @dmytrorykun, can you provide any insight? I remember that we had a similar report of react-native.config.js not being picked up by Codegen, but I remember we fixed that already. 🤔

[ospfranco]

For Android, I'm not sure this is the error I'm seeing? seems it doesn't like that I use the CallInvokerHolderImpl reference and it fails the compilation? How am I supposed to get a hold of the CallInvoker?

The class

package com.op.sqlite

import com.facebook.react.bridge.ReactContext
import com.facebook.react.turbomodule.core.CallInvokerHolderImpl

class OPSQLiteBridge {
 private external fun installNativeJsi(
 jsContextNativePointer: Long,
 jsCallInvokerHolder: CallInvokerHolderImpl,
 docPath: String
 )

 private external fun clearStateNativeJsi()
 fun install(context: ReactContext) {
 val jsContextPointer = context.javaScriptContextHolder!!.get()
 val jsCallInvokerHolder =
 context.catalystInstance.jsCallInvokerHolder as CallInvokerHolderImpl
 // Trick to get the base database path
 val dbPath =
 context.getDatabasePath("defaultDatabase").absolutePath.replace("defaultDatabase", "")
 installNativeJsi(
 jsContextPointer,
 jsCallInvokerHolder,
 dbPath
 )
 }

 fun clearState() {
 clearStateNativeJsi()
 }

 companion object {
 val instance = OPSQLiteBridge()
 }
}

The error logs:

e: file:///Users/osp/Developer/op-sqlite/android/src/main/java/com/op/sqlite/OPSQLiteBridge.kt:9:30 This API is provided only for React Native frameworks and not intended for general users. This API can change between minor versions in alignment with React Native frameworks and won't be considered a breaking change.
e: file:///Users/osp/Developer/op-sqlite/android/src/main/java/com/op/sqlite/OPSQLiteBridge.kt:17:61 This API is provided only for React Native frameworks and not intended for general users. This API can change between minor versions in alignment with React Native frameworks and won't be considered a breaking change.
e: file:///Users/osp/Developer/op-sqlite/android/src/main/java/com/op/sqlite/OPSQLiteBridge.kt:21:9 This API is provided only for React Native frameworks and not intended for general users. This API can change between minor versions in alignment with React Native frameworks and won't be considered a breaking change.
e: file:///Users/osp/Developer/op-sqlite/android/src/main/java/com/op/sqlite/OPSQLiteBridge.kt:23:13 This API is provided only for React Native frameworks and not intended for general users. This API can change between minor versions in alignment with React Native frameworks and won't be considered a breaking change.

[cortinico]

For Android, I'm not sure this is the error I'm seeing? seems it doesn't like that I use the CallInvokerHolderImpl reference and it fails the compilation? How am I supposed to get a hold of the CallInvoker?

You're seeing this error because you're using CallInvokerHolderImpl which is annotated as FrameworksAPI. This is a more advanced API that should be used only if you know what you're doing.

1. Can I ask you why do you need to access CallInvokerHolderImpl.
2. What's your use case?
3. What does the installNativeJsi method does?

For the time being, you can overcome this build failure by annotating your class with:

import com.facebook.react.common.annotations.FrameworkAPI

@OptIn(FrameworkAPI::class)
class OPSQLiteBridge {
 ...
}