[Android] No API for updating props on android root component

[jaredly]

In iOS, you can do rctRootView.appProperties = newProps, and it will update the root view with new props. On android it doesn't seem to be implemented.

This behavior is critical for my use case of incrementally adopting react native in a large android app.

I think I want a function like ReactRootView.updateProps(Bundle props) that would look something like

public void updateProps(Bundle newProps) {
 WritableNativeMap appParams = new WritableNativeMap();
 Double rootTag = MagicallyGetTheRootTag() // <- the rootTag isn't actually stored anywhere at the moment
 appParams.putDouble("rootTag", rootTag);
 appParams.putMap("initialProps", newProps);
 final CatalystInstance catalystInstance = mReactInstanceManager.getCurrentReactContext().getCatalystInstance();
 String jsAppModuleName = this.getJSModuleName();
 catalystInstance.getJSModule(AppRegistry.class).runApplication(jsAppModuleName, appParams);
}

based on the startReactApplication fn

Before I made a PR I wanted to check my direction -- does it look reasonable? I think I'll have to store the rootTag on the ReactRootView instance, b/c I can't find anywhere else that it's already stored.

[brentvatne]

@bestander - could you check this out to see if it's reasonable? This is part of getting parity with iOS, cc @mkonicek

[bestander]

Will do on Tuesday

On Sunday, 6 March 2016, Brent Vatne notifications@github.com wrote:

@bestander https://github.com/bestander - could you check this out to
see if it's reasonable? This is part of getting parity with iOS, cc
@mkonicek https://github.com/mkonicek

—
Reply to this email directly or view it on GitHub
#6303 (comment)
.

[brentvatne]

🚀

[bestander]

@jaredly go for it, we would appreciate this feature.
Ping me with the PR.

[jaredly]

ok so my initial attempt was unsuccessful (pretty much doing what I outlined above), and we've decided not to invest in RN yet, so it's unlikely I'll dig into this further in the near future

[bestander]

No worries, we'll do it eventually.
Would you mind giving feedback why you have decided to not proceed with RN right now?
Any particular pain or aspect you think we should address?

[jaredly]

mostly immaturity of android, and to a lesser extent iOS. We have large apps that we're thinking of integrating react native into incrementally, which definitely isn't a well-documented use case. we're planning on doing further investigation in a few months and might have a different decision depending on how things have matured.

[bestander]

👍
Thanks, this gives some very important feedback.

[MikeOrtiz]

@bestander What is the status of this feature request? My use case requires inserting a RN view in a native ListView. Removing and creating new react views doesn't allow for smooth scrolling and emitting events with prop updates sends the same props to all children.

Is the feature currently being worked on? If not, what might it involve to implement?