Skip to content

Make sure xhr req header's value is String type - #10222

Closed
leeight wants to merge 1 commit into
react:masterfrom
leeight:fix-10198
Closed

Make sure xhr req header's value is String type#10222
leeight wants to merge 1 commit into
react:masterfrom
leeight:fix-10198

Conversation

@leeight

@leeightleeight commented Oct 3, 2016

Copy link
Copy Markdown
Contributor

In the NetworkingModule.java, header.getString(1) was
called, so the value must be String type.

FIX#10198

@facebook-github-bot

facebook-github-bot commented Oct 3, 2016

Copy link
Copy Markdown
Contributor

By analyzing the blame information on this pull request, we identified @philikon and @davidaurelio to be potential reviewers.

@facebook-github-botfacebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 3, 2016
leeight
leeight commented Oct 3, 2016
View reviewed changes
Comment threadReactAndroid/src/test/java/com/facebook/react/modules/BUCK Outdated

@leeightleeightOct 3, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing deps, make scripts/run-android-local-unit-tests.sh happy

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2016
@facebook-github-bot

facebook-github-bot commented Oct 7, 2016

Copy link
Copy Markdown
Contributor

@leeight updated the pull request - view changes

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2016
@facebook-github-bot

facebook-github-bot commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

@leeight updated the pull request - view changes

leeight
leeight commented Oct 12, 2016
View reviewed changes
Comment threadLibraries/Network/XMLHttpRequest.js Outdated

@leeightleeightOct 12, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the NetworkingModule.java, header.getString(1) was called, so the value must be String type.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 12, 2016
@leeight

leeight commented Oct 14, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

cc @satya164@janicduplessis

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2016
@facebook-github-bot

facebook-github-bot commented Oct 21, 2016

Copy link
Copy Markdown
Contributor

@leeight updated the pull request - view changes

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2016
@lackerlacker self-assigned this Oct 25, 2016
@lacker

lacker commented Oct 25, 2016

Copy link
Copy Markdown
Contributor

Arguably code should not be using this but it seems worth it to get firebase files working. The dependency thing looks like it already got fixed, though, so now Circle CI is complaining that that dependency is a duplicate. Could you fix that and then I'll ship this?

@leeight
Make sure xhr req header's value is String type
c73546a
In the `NetworkingModule.java`, `header.getString(1)` was
called, so the value must be String type.
FIXreact#10198
@leeight

leeight commented Oct 26, 2016

Copy link
Copy Markdown
ContributorAuthor

@lacker Done.

@lacker

lacker commented Oct 26, 2016

Copy link
Copy Markdown
Contributor

@facebook-github-bot shipit

@facebook-github-botfacebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Oct 26, 2016
@facebook-github-bot

facebook-github-bot commented Oct 26, 2016

Copy link
Copy Markdown
Contributor

@lacker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lackerlacker

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Import StartedThis pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leeight@facebook-github-bot@lacker