Skip to content

Update GettingStarted.md if user using zsh filename should be .zshrc - #10432

Closed
vadimeremeev wants to merge 2 commits into
react:masterfrom
vadimeremeev:patch-2
Closed

Update GettingStarted.md if user using zsh filename should be .zshrc#10432
vadimeremeev wants to merge 2 commits into
react:masterfrom
vadimeremeev:patch-2

Conversation

@vadimeremeev

@vadimeremeevvadimeremeev commented Oct 18, 2016

Copy link
Copy Markdown

Small contribution for MacOS users:

For those users who using zsh with their Mac OS filename to place variables should be different

@vadimeremeev
if user using zsh filename should be .zshrc
d8f32f3
For those users who using zsh with their Mac OS filename to place variables should be different
@facebook-github-bot

facebook-github-bot commented Oct 18, 2016

Copy link
Copy Markdown
Contributor

By analyzing the blame information on this pull request, we identified @hramos and @JoelMarcey to be potential reviewers.

@facebook-github-botfacebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 18, 2016
@hramos

hramos commented Oct 18, 2016

Copy link
Copy Markdown
Contributor

Curious, how many Mac users switch to zsh? I thought about adding callouts like these for other shells, but figured if you switched your shell, you would likely also know to map .bashrc to whatever your shell uses instead.

@vadimeremeev

vadimeremeev commented Oct 19, 2016

Copy link
Copy Markdown
Author

Yup, for sure can figure it out. Just that it might take extra time if developers follow guide exactly step by step.

Also on another page I notice it was explained in details:
http://facebook.github.io/react-native/releases/0.35/docs/android-building-from-source.html#point-gradle-to-your-android-sdk

@lacker

lacker commented Oct 25, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

I agree with the sentiment and just tweaked the wording a bit. Thanks!

@lacker

lacker commented Oct 25, 2016

Copy link
Copy Markdown
Contributor

@facebook-github-bot shipit

@facebook-github-botfacebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Oct 25, 2016
@facebook-github-bot

facebook-github-bot commented Oct 25, 2016

Copy link
Copy Markdown
Contributor

@lacker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Import StartedThis pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vadimeremeev@facebook-github-bot@hramos@lacker