Uh oh!
There was an error while loading. Please reload this page.
Integration test stability: add delay before starting TimersTest - #10548
Integration test stability: add delay before starting TimersTest#10548douglowder wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Oct 26, 2016
By analyzing the blame information on this pull request, we identified @sebmarkbage to be a potential reviewer. |
douglowder
commented
Oct 26, 2016
@bestander here's another change that I think might improve test stability.... |
bestander
commented
Oct 26, 2016
@facebook-github-bot shipit |
facebook-github-bot
commented
Oct 26, 2016
@bestander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
bestander
commented
Oct 26, 2016
Thanks, @dlowder-salesforce. I looked at the last 10 build failures on Master branch https://travis-ci.org/facebook/react-native/builds/170729100 |
douglowder
commented
Oct 26, 2016
@bestander Looks like there are intermittent failures with testLogging and testPropertiesUpdateTest. The latter happens when the simulator won't come up sometimes, and can also happen in objc-test-ios. The logging test failures seem to be cases where the message text doesn't match expected values when running the tvOS tests. It's a bit strange -- I would expect those failures to happen every time, or not at all. I'll take a look. |
douglowder
commented
Oct 26, 2016
Interesting.... If I restart the packager and remove UIExplorer app from the tvOS simulator, it seems to fail every time, but not always at the same line. Bizarre. It succeeds after that. |
douglowder
commented
Oct 26, 2016
@bestander Found the issue. On tvOS, logging messages (due to missing components that don't exist in tvOS) are arriving at the same time as the test log messages, causing intermittent test failures. Submitting a PR to fix this. |
Locally I'm seeing consistent failures in IntegrationTests/TimersTest.js. Adding a little delay before starting the first test seems to make these issues go away.