Uh oh!
There was an error while loading. Please reload this page.
Omit all line terminators for ImageStore.getBase64ForTag - #11155
Closed
leeight wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Nov 27, 2016
Contributor
By analyzing the blame information on this pull request, we identified @AaaChiuuu to be a potential reviewer. |
mkonicek
commented
Nov 28, 2016
Contributor
"Manually" is not a test plan. You'll need to explain how exactly you tested this - what commands you ran, what their output was. |
lacker
commented
Dec 15, 2016
Contributor
I think better than a "test plan" would just be a unit test ensuring that this works correctly. |
hramos
commented
Jan 19, 2017
Contributor
Ping @leeight, see lacker's feedback above. |
FnTm
commented
May 8, 2017
Contributor
I'll take a stab at coming up with some tests for this |
FnTm
commented
May 9, 2017
Contributor
I didn't know how to add/change commits for this PR, so I created a new one that fixes this problem #13856 |
facebook-github-bot pushed a commit
that referenced
this pull request
Oct 10, 2017
Summary: FIX#11142 This fixes#11142 and supersedes #11155 as I was unsure how to add/change commits in that PR. Wrote up a bunch of unit tests for the ImageStore module. The added tests showed that there was indeed a problem with the flags used for the Base64OutputStream, and they also show that that has been fixed now. Closes#13856 Differential Revision: D6017764 Pulled By: shergin fbshipit-source-id: adf667dc722ddfe31449afd8cd20a0a192eacff6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageStore.getBase64ForTag result should omit the line terminators, and fix#11142
Test plan (required)
Manually.