Uh oh!
There was an error while loading. Please reload this page.
Fixes #5688 onChangeVisibleRows for Android - #11945
Conversation
facebook-github-bot
commented
Jan 17, 2017
By analyzing the blame information on this pull request, we identified @AaaChiuuu and @foghina to be potential reviewers. |
ptomasroos
commented
Jan 26, 2017
@hramos Can we get someone to look at this ? |
Since the ScrollEvent pool throttles updates before could be missed in the case of very fast scrolling. These scheduled update frames are now being merged in the case an event is within the pool.
nxnzesrc
commented
Feb 1, 2017
Does anyone know when this might be released please? |
vitorebatista
commented
Feb 12, 2017
Why this PR is close? |
ptomasroos
commented
Feb 12, 2017
via email
No need for it now when flatlist is available. |
nxnzesrc
commented
Feb 12, 2017
flatlist? |
philipheinser
commented
Feb 14, 2017
@ptomasroos Can we use flat list in rn-0.42.0 or do we have to checkout master? |
dthuering
commented
Feb 22, 2017
Would still be nice when that error would be fixed anyway. |
rborn
commented
Feb 22, 2017
@ptomasroos why can't this be merged? FlatList is still experimental and people still use the normal listview... |
ptomasroos
commented
Feb 22, 2017
No one took a look on it for quite some time. Feel free to copy the branch and open a PR if you need it! We've migrated to FlatList |
philipheinser
commented
Feb 22, 2017
@ptomasroos How can I use FlatList right now? Do you use the master branch? |
This PR includes a fix for the old missing feature of onChangeVisibleRows on Android.
Fixes#5688
Also reported on product pains https://productpains.com/post/react-native/listview-onchangevisiblerows-android-support
Test plan (required)
Test through UIExplorer which has a callback on the ListView Paging example and walking through rows + sections and making sure visible rows matches to whats visible.