Skip to content

Fix typo in ResolutionRequest.js - #11983

Closed
radko93 wants to merge 2 commits into
react:masterfrom
radko93:patch-1
Closed

Fix typo in ResolutionRequest.js#11983
radko93 wants to merge 2 commits into
react:masterfrom
radko93:patch-1

Conversation

@radko93

Copy link
Copy Markdown
Contributor

Small fix:
Fix typo in error message - should be npm start --reset-cache

Fix:
Fix typo in error message - should be `npm start --reset-cache`
@facebook-github-botfacebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 19, 2017
@facebook-github-botfacebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jan 20, 2017
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@radko93
radko93 deleted the patch-1 branch January 21, 2017 12:33
cpojer pushed a commit to react/metro that referenced this pull request Jan 26, 2017
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closesreact/react-native#11983
Reviewed By: AsyncDBConnMarkedDownDBException
Differential Revision: D4443749
Pulled By: hramos
fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
@cooperka

cooperka commented Mar 15, 2017

Copy link
Copy Markdown
Contributor

Hi @radko93, this doesn't work for me without the double dash. I thought the -- was necessary to pass the --reset-cache flag through to node node_modules/react-native/local-cli/cli.js start instead of applying it to npm start. Is it possibly project dependent?

@radko93

Copy link
Copy Markdown
ContributorAuthor

It could be related to npm or node version.

@cooperka

Copy link
Copy Markdown
Contributor

Hmm, based on the comments here it looks like using the double dash is much more common. I honestly don't know how it would work without it, since npm doesn't understand that flag and it needs to be passed through.

Do you think we should open an issue, or how should this be resolved? If it truly works for you without the double dash, something very weird is going on 😕

@radko93 I'm on node v7.7.1, npm v4.1.2, and RN v0.42.0, what about you?

@hramos

Copy link
Copy Markdown
Contributor

@cooperka I merged this in and I'm willing to look at a PR to revert this if it turns out to be inaccurate.

cooperka added a commit to cooperka/react-native that referenced this pull request Mar 18, 2017
As discussed in react#11983. The double dash is necessary to pass through the argument to node. Based on the comments [here](react#1924 (comment)), it looks like most people use the double dash; it's unclear whether it would do anything at all if the dashes were omitted. If anyone else has better insight, let me know!
@hramos please review, thank you.
This reverts commit f521e99.
facebook-github-bot pushed a commit to react/metro that referenced this pull request Mar 18, 2017
Summary:
As discussed in react/react-native#11983. The double dash is necessary to pass through the argument to node. Based on the comments [here](react/react-native#1924 (comment)), it looks like most people use the double dash; it's unclear whether it would do anything at all if the dashes were omitted. If anyone else has better insight, let me know!
Closesreact/react-native#13003
Differential Revision: D4731566
Pulled By: hramos
fbshipit-source-id: 62562536db7589a03a511762117cbf0e36d3aafb
facebook-github-bot pushed a commit that referenced this pull request Mar 18, 2017
Summary:
As discussed in #11983. The double dash is necessary to pass through the argument to node. Based on the comments [here](#1924 (comment)), it looks like most people use the double dash; it's unclear whether it would do anything at all if the dashes were omitted. If anyone else has better insight, let me know!
Closes#13003
Differential Revision: D4731566
Pulled By: hramos
fbshipit-source-id: 62562536db7589a03a511762117cbf0e36d3aafb
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Import StartedThis pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@radko93@facebook-github-bot@cooperka@hramos