Uh oh!
There was an error while loading. Please reload this page.
Add more documentation in ListViewDataSource - #1285
Conversation
ListViewDataSource's default data extractor can actually expect another data form:
`{ sectionID_1: [ <rowData1>, <rowData2>, ... ], ... }`sahrens
commented
May 15, 2015
@facebook-github-bot import |
facebook-github-bot
commented
May 15, 2015
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1593093057609165/int_phab to review. |
sahrens
commented
May 15, 2015
Thanks for the fix! In the future, please make sure to clean up trailing spaces and any other lint. |
umhan35
commented
May 15, 2015
Sorry, I just added something in the comment. Why do we need to clean up trailing spaces and any other lint in this context? |
sahrens
commented
May 15, 2015
code is code and lint is lint, whether it's a comment or not. |
umhan35
commented
May 16, 2015
OK. I just noticed that there are trailing spaces. I didn't mean it and it's hard to find. Sorry. |
sahrens
commented
May 16, 2015
Some editors can be configured to automatically remove trailing whitespace which is nice. Does running lint pick up these issues for you?
|
umhan35
commented
May 16, 2015
Oh, I edited the file using GitHub's edit button because I think the change is minor... (My IDE, WebStorm, for my react native project has the automatic trailing space removal feature.) I'm new to node.js and |
umhan35
commented
May 19, 2015
Thank you @sahrens! Just saw the update of CONTRIBUTING.md |
ListViewDataSource's default data extractor can actually expect another data form:
{ sectionID_1: [ <rowData1>, <rowData2>, ... ], ... }