Uh oh!
There was an error while loading. Please reload this page.
Fix IP detection on Mac with loopback - #12875
Closed
hilkeheremans wants to merge 367 commits into
Closed
Conversation
Summary: remove `copyProperties` module, and replace the functionality with `Object.assign` Reviewed By: javache Differential Revision: D4745771 fbshipit-source-id: 2440620757e7539dbd7fd39f5920ac0b5b4183c5
Summary: Only pulls in `EventValidator` for development mode, as warnings about invalid events are pointless in production builds. Reviewed By: javache Differential Revision: D4745852 fbshipit-source-id: dbab1026df35d54a82e1e620fac08304c58fbeae
Reviewed By: davidaurelio Differential Revision: D4746429 fbshipit-source-id: 1a49a4b6db75658749346f0fd94dad68ff084203
Differential Revision: D4713064 fbshipit-source-id: 511b782279b89076228f00290e78ed155e2e723e
Reviewed By: fkgozali Differential Revision: D4746177 fbshipit-source-id: a8c27ec052b046d4732b14ed081dcaebb44bdaa7
Summary: Bug in Android https://code.google.com/p/android/issues/detail?id=33868 causes the RN catalyst instrumentation test to fail with ``` java.lang.ArrayIndexOutOfBoundsException: length=253; index=-1 at android.text.StaticLayout.calculateEllipsis(StaticLayout.java:667) at android.text.StaticLayout.out(StaticLayout.java:631) at android.text.StaticLayout.generate(StaticLayout.java:423) ... ``` The fix is to set singleLine to true when there is only one line of text Reviewed By: AaaChiuuu Differential Revision: D4562000 fbshipit-source-id: 84248e3982063b767e8b0465effe2321b54a7fa2
Summary: We recommend using `react-navigation` over `Navigator`. Adds a link to the new `native-navigation` component as well. Did not test website generation, this is a comments only edit that should work fine. Closesreact#12963 Differential Revision: D4749072 Pulled By: hramos fbshipit-source-id: 4506630306c44b24b95c4f5d5a42c1caa9e2cd4e
Summary: Some quick copy changes. Closesreact#13061 Differential Revision: D4749511 Pulled By: hramos fbshipit-source-id: 5b6f67be40ed071367507ac3c87f7ac67a0584e7
… to clear the frame callback on Reviewed By: achen1 Differential Revision: D4741906 fbshipit-source-id: 2d5fabab6e04c08252513f77149c04e3b8314d2c
Summary: The returned value from Linking.getInitialURL is a promise that returns an url. Can be seen here: https://github.com/facebook/react-native/blob/f126540519bd276c0048aa77b543dc863412de46/Libraries/Linking/Linking.js#L175Closesreact#12851 Differential Revision: D4716084 Pulled By: hramos fbshipit-source-id: 309881cfb423a5c9a3f9010ae7ca226b63c91599
Reviewed By: javache Differential Revision: D4679644 fbshipit-source-id: f53e554e283fdb0b59c41623e690fd1a21e03a57
Reviewed By: javache Differential Revision: D4679655 fbshipit-source-id: 8123488c2d50dd7cc2329b5131e99998fe1f1e2f
Reviewed By: yungsters Differential Revision: D4726519 fbshipit-source-id: 1ae98743cdb89acb2708d84073527015dbeee906
Summary: People might be tempted to try and scrollTo an index that hasn't been rendered yet, which is broken, so instead of jank let's throw. Reviewed By: yungsters Differential Revision: D4727402 fbshipit-source-id: b6f9fd5b70b6f076c30141d00b2b9e2a51b14e87
Reviewed By: yungsters Differential Revision: D4688309 fbshipit-source-id: 4e1c70039050170cc0bc2eca0bba0fd077c692d2
Summary: This adds support for both automagical sticky section headers in `SectionList` as well as the more free-form `stickyHeaderIndices` on `FlatList` or `VirtualizedList`. The basic concept is to take the initial `stickySectionHeaders` and remap them to the indices corresponding to the mounted subset in the render window. The main trick here is that the currently stuck header might itself be outside of the render window, so we need to search the gap to see if that's the case and render it (with spacers above and below it instead of one big spacer). In the `SectionList` we simply pre-compute the sticky headers at the same time as when we scan the sections to determine the flattened length and pass those to `VirtualizedList`. This also requires some updates to `ScrollView` to work in the churny environment of `VirtualizedList`. We propogate the keys on the children to the animated wrappers so that as items are removed and the indices of the remaining items change, react can keep proper track of them. We also fix the scroll back case where new headers are rendered from the top down and aren't updated with the `setNextLayoutY` callback because the `onLayout` call for the next header happened before it was mounted. This is done by just tracking all the layout values in a map and providing them to the sticky components at render time. This might also improve perf a little by property configuring the animations syncronously instead of waiting for the `onLayout` callback. We also need to protect against stale onLayout callbacks and other fun stuff. == Test Plan == https://www.facebook.com/groups/react.native.community/permalink/940332509435661/ Scroll a lot with and without debug mode on. Make sure spinner still spins and there are no crashes (lots of crashes during development due to the animated configuration being non-monotonic if anything stale values get through). Also made sure that tapping a row to change it's height would properly update the animation configurations so the collision point would still be correct. Reviewed By: yungsters Differential Revision: D4695065 fbshipit-source-id: 855c4e31c8f8b450d32150dbdb2e07f1a9f9f98e
Summary:
It was just adding unnecessary complexity. Users should just use standard React perf best practices, like `PureComponent` and `shouldComponentUpdate`.
This should be backwards compatible - existing `shouldItemUpdate` usage will just be ignored and should consider migrating to this pattern:
```
class MyItem extends React.PureComponent {
_onPress = () => {
this.props.onPressItem(this.props.id);
};
render() {
return (
<SomeOtherWidget title={this.props.title} onPress={this._onPress} />
)
}
}
...
_renderItem = ({item}) => (
<MyItem onPressItem={this._onPressItem} title={item.title} id={item.id} />
);
```
Which will automatically prevent re-renders unless the relavent data changes.
Reviewed By: yungsters
Differential Revision: D4730599
fbshipit-source-id: 0f61efe96eb4d95bb3b7c4ec889e3e0e34436e56…for consistency Summary: Not sure how I missed this in react@3ce31c2 Reviewed By: yungsters Differential Revision: D4731083 fbshipit-source-id: 860ed9d2f99312cd02b84ba467ba66afc5cdd5c5
Reviewed By: blairvanderhoof, bvaughn Differential Revision: D4742842 fbshipit-source-id: a11a088194ead02cc11eb6ccd9ce6d6f75ead3a3
Summary: It's supposed to take a component or a handle, per the arg name, so switch on the type (and handle `null`). `FlatListExample` no longer crashes. Reviewed By: bvaughn, sebmarkbage Differential Revision: D4752619 fbshipit-source-id: 720421f648f7c2049b5cc44f006484eb47d22d86
Summary: 1. Mention scrollToIndex support. 2. Fix a format error. 3. Use relative links like https://github.com/facebook/react-native/blob/59257d6976656f4eeaf389ae5527dfaff08e7354/Libraries/Components/Navigation/NavigatorIOS.ios.js#L136 for links in "next version" to work properly. ~~4. BREAKING: `columnWrapperStyle` should be `rowWrapperStyle`?~~ Closesreact#12714 Differential Revision: D4730476 Pulled By: sahrens fbshipit-source-id: 643aab659064e6f5275ec89fd7f967dd9de866c4
…ions Reviewed By: davidaurelio Differential Revision: D4745529 fbshipit-source-id: 2c69aca33c999ccf2af8dbf8d9af2c1d123b59cd
Reviewed By: alexeylang Differential Revision: D4749516 fbshipit-source-id: 348f1cf51c01b39a410be8b39598e8e98cd52d55
Reviewed By: AaaChiuuu Differential Revision: D4749896 fbshipit-source-id: 8a3f12e5d7b209c48c95f8564d8e3bcbd19f90c8
Summary: As per uglify-js maintainer kzc's comment in mishoo/UglifyJS#1573 (comment) we should be locking our version to prevent issues like react#12772 from happening again. No test plan needed, people are already using this version of uglify-js (it's the latest). Closesreact#12802 Differential Revision: D4749853 Pulled By: javache fbshipit-source-id: 866a19cb2c1add31b55e14d0f4dadb7f68fda64c
Reviewed By: davidaurelio Differential Revision: D4751434 fbshipit-source-id: 1be748387abe9ca0ce030bd2423827dfe5c2a146
Reviewed By: davidaurelio Differential Revision: D4745885 fbshipit-source-id: 3d327e5ca91fcbe7ec1d30ff8e6135b415074aa4
Reviewed By: javache Differential Revision: D4746020 fbshipit-source-id: cfc9de286feeac49b4b569560dc29c7a1c25eee1
Reviewed By: shergin Differential Revision: D4821772 fbshipit-source-id: 2cd35ec6726b6fe1494a92966ade5aa0b86e769b
Reviewed By: shergin Differential Revision: D4823509 fbshipit-source-id: 79c96d3bc183d89a5dec7da06b0a0a710d8c7dea
…eners are attached Summary: Resolvesreact#13012 RCTPushNotificationManager uses startObserving to register for RCTRegisterUserNotificationSettings. According to the docs, the startObserving method won't be called until somebody subscribes to NotificationManagerIOS. This means there is a scenario when the developer can call requestPermissions without subscribing to notifications first, but since RCTPushNotificationManager relies on NSNotificationCenter subscribtion, the result will never be returned. When requesting permissions the promise will resolve: `PushNotificationIOS.requestPermissions().then(console.log);` without the need for calling `PushNotificationIOS.addEventListener()` first. Closesreact#13263 Differential Revision: D4851767 Pulled By: javache fbshipit-source-id: 2be8621e072ae1086014594bc986ca5590b5eb61
Summary: On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, expo/create-react-native-app#101, expo/create-react-native-app#113 (comment) for examples of users hitting this in the wild), even though no package management action is being taken. From what I can tell this is what happens: * [`local-cli/util/yarn.js` does not ignore stderr on Windows](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/yarn.js#L25) * [`local-cli/util/PackageManager.js` calls the above function when it's require'd](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/PackageManager.js#L20) For Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays wh Closesreact#13355 Differential Revision: D4848084 Pulled By: hramos fbshipit-source-id: f32176354e0bd7ff6d7009ea30dca64ff23ae3d5
Summary: prevents reflected classes from being stripped/obfuscated Depends on D4830910 Reviewed By: mhorowitz Differential Revision: D4835688 fbshipit-source-id: 5b85668f92ed4ae5cebc9902ec60f6d5d6299bd4
…iews Reviewed By: sahrens Differential Revision: D4786713 fbshipit-source-id: af9cef0737c010b429d52d00181c00bd81f13f5b
javache
commented
Apr 7, 2017
Contributor
Can you please rebase this change? It's failing to apply internally. |
Summary: If the new state depends on the previous state, if I remember correctly, it’s safer to use `setState()` with a function argument to ensure we’re not reading from an outdated `state`. Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. The tutorial suggests to use `setState()` with an object argument when the new state depends on the previous state. In such situations, it’s preferable to use a function to ensure the previous state is up-to-date. Updates documentation only, so there are no additional tests. Rendering the site. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure th Closesreact#13358 Differential Revision: D4852404 Pulled By: hramos fbshipit-source-id: 834759e16bcfbd5a8de71bf0c56f2b154f3321e1
Reviewed By: thechefchen Differential Revision: D4853991 fbshipit-source-id: b024d4052edb04e9f9da2e2504c56f8b7840cded
Summary: Closesreact#13389 Differential Revision: D4854128 Pulled By: hramos fbshipit-source-id: bd7d0d12eae51fed31cf4bc2260b8c4f447e08c8
Reviewed By: tomocchino Differential Revision: D4850695 fbshipit-source-id: 8aae4353de8779f7a1358b2766dad4a6c751b4af
Summary: When running an app on a real iPhone in debug mode, I occasionally get issues when trying to load the js bundle and I suspect the issue is with xip.io (and it doesn't look like I'm the only one: react#12786react#9688 (comment)). So I've added the ability to optionally disable the use of xip.io if an env variable `DISABLE_XIP` is set. Add `export DISABLE_XIP=true` to the `Bundle React Native code and images` build phase. Run the app on a real iPhone and ensure that it can load the JS bundle from the host computers IP. Closesreact#13326 Differential Revision: D4855719 Pulled By: ericvicenti fbshipit-source-id: cb2e91291acadaa78ea302800b55c2e5388f6380
facebook-github-bot
commented
Apr 8, 2017
Contributor
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
Reviewed By: nmote Differential Revision: D4851923 fbshipit-source-id: 018f61c3a45e32c899287848d36129e3601145a4
Reviewed By: mhorowitz Differential Revision: D4851596 fbshipit-source-id: cf5f5c51b9aaa0da96f7ab6fba1277b72c988400
Reviewed By: dcaspi Differential Revision: D4829671 fbshipit-source-id: 6b1cef1d31c7d8981c6f1e304d3742e885f8a83b
Summary: Adds functionality to be able to disable saving of form data and thereby disabling autocomplete in webview on Android. Can be used as a workaround for react#13241 Manual testing that autocomplete is disabled when the property is set to true, and still enabled when it is unset or set to false. Closesreact#13271 Differential Revision: D4858899 Pulled By: ericvicenti fbshipit-source-id: 62738b0685e4c1958c8a32e184fa2fe4f711b336
Filters everything starting with `127.`
…jing/react-native into fix-mac-ip-detection-loopback # Conflicts: # packager/react-native-xcode.sh
hilkeheremans
commented
Apr 10, 2017
ContributorAuthor
Done, merge conflict resolved. Let's see how this goes. |
javache
commented
Apr 10, 2017
Contributor
Looks like something went wrong with the rebase (see the Files changed tab). Can you try again? |
hilkeheremans
commented
Apr 10, 2017
ContributorAuthor
That's very odd. I must have made a mistake somewhere - monday morning after a heavy weekend ;-) Anyway, rather than risk messing this particular PR up even more, see PR #13415. |
facebook-github-bot pushed a commit
that referenced
this pull request
Jun 16, 2018
Summary: This sync includes the following changes: - **[ae14317](react/react@ae14317d6)**: Inline fbjs/lib/emptyFunction (#13054) //<Dan Abramov>// - **[72434a7](react/react@72434a768)**: Remove or inline some fbjs dependencies (#13046) //<Dan Abramov>// - **[64c54ed](react/react@64c54edea)**: Adding movementX and movementY to synthenticMouseEvent fixes#6723 (#9018) //<Jason Williams>// - **[9bd4d1f](react/react@9bd4d1fae)**: Synchronously restart when an error is thrown during async rendering (#13041) //<Andrew Clark>// - **[9bda7b2](react/react@9bda7b28f)**: Suspended high pri work forces lower priority work to expire early (#12965) //<Andrew Clark>// - **[2e75779](react/react@2e7577907)**: Fix incorrect data in compositionend event with Korean IME on IE11 (#10217) (#12563) //<Crux>// - **[bc963f3](react/react@bc963f353)**: setJSResponder in Fabric renderer (#13031) //<Sebastian Markbåge>// - **[051637d](react/react@051637da6)**: Extract Fabric event handlers from canonical props (#13024) //<Sebastian Markbåge>// - **[2a80859](react/react@2a8085980)**: Remove rAF fork (#12980) //<Flarnie Marchan>// - **[e0c7834](react/react@e0c78344e)**: Retry on error if there's lower priority pending work (#12957) //<Andrew Clark>// - **[9725065](react/react@9725065eb)**: Update bundle sizes for 16.4.1 release //<Dan Abramov>// - **[0b87b27](react/react@0b87b2790)**: Updating package versions for release 16.4.1 //<Dan Abramov>// - **[036ae3c](react/react@036ae3c6e)**: Use native event dispatching instead of Simulate or SimulateNative (#13023) //<Philipp Spieß>// - **[945fc1b](react/react@945fc1bfc)**: Call gDSFP with the right state in react-test-render (#13030) //<Rafał Ruciński>// - **[3925301](react/react@392530104)**: Remove feature flag around 'getDerivedStateFromProps' bug fix (#13022) //<Flarnie Marchan>// - **[1594409](react/react@1594409fa)**: Scheduler depends on common packages (#13020) //<Dan Abramov>// - **[d5c1119](react/react@d5c11193e)**: Added production profiling bundle type (#12886) //<Brian Vaughn>// - **[ec60457](react/react@ec60457bc)**: Popping context is O(1) in SSR (#13019) //<Dan Abramov>// - **[30bc8ef](react/react@30bc8ef79)**: Allow multiple root children in test renderer traversal API (#13017) //<Dan Abramov>// - **[d480782](react/react@d480782c4)**: Don’t error when returning an empty Fragment (#12966) //<Philipp Spieß>// - **[4ac6f13](react/react@4ac6f133a)**: Fallback to event.srcElement for IE9 (#12976) //<Nathan Hunzaker>// - **[23be410](react/react@23be4102d)**: Fixed an issue with nested contexts unwinding when server rendering. Issue #12984 (#12985) //<Eric Soderberg>// - **[d0d4280](react/react@d0d428064)**: Remove old reference to inst._wrapperState (#12987) //<Nathan Hunzaker>// - **[c78957e](react/react@c78957eac)**: Fix an SVG focusing crash in IE11 (#12996) //<Jifa Jiang>// - **[bfb12eb](react/react@bfb12ebb5)**: delete a couple of redundant lines in performWorkOnRoot() in ReactFiberScheduler.js (#13003) //<Nathan Quarles>// - **[394b17e](react/react@394b17eed)**: Update custom renderer docs //<Dan Abramov>// - **[188c425](react/react@188c4252a)**: Fix react-dom ReferenceError requestAnimationFrame in non-browser env (#13000) (#13001) //<Ivan Babak>// - **[9cf3733](react/react@9cf3733a9)**: update comment in computeAsyncExpiration() to reflect code (#12994) //<Nathan Quarles>// - **[c5a733e](react/react@c5a733e1e)**: Fix links of docs on the comment (#12795) //<Ende93>// - **[36546b5](react/react@36546b513)**: Set the correct initial value on input range (#12939) //<Maxime Nory>// - **[15767a8](react/react@15767a8f8)**: [scheduler] 5/n Error handling in scheduler (#12920) //<Flarnie Marchan>// - **[3118ed9](react/react@3118ed9d6)**: Expose unstable_interactiveUpdates on ReactDOM (#12943) //<Andrew Clark>// - **[524a743](react/react@524a74331)**: Fix for Flow issues in SimpleCacheProvider (#12942) //<Flarnie Marchan>// - **[ae57b12](react/react@ae57b125c)**: [simple-cache-provider] Use LRU cache eviction (#12851) //<Andrew Clark>// - **[e0a03c1](react/react@e0a03c1b4)**: Extend input type check in selection capabilities (#12062) (#12135) //<Spyros Ioakeimidis>// - **[79a740c](react/react@79a740c6e)**: Rename variables to remove references to 'global' global (#12931) //<Flarnie Marchan>// - **[ff724d3](react/react@ff724d3c2)**: [scheduler] 4/n Allow splitting out `schedule` in fb-www, prepare to fix polyfill issue internally (#12900) //<Flarnie Marchan>// - **[83f76e4](react/react@83f76e4db)**: ForwardRefs supports propTypes (#12911) //<Brian Vaughn>// - **[8aeea5a](react/react@8aeea5afa)**: Do not assign node.value on input creation if no change will occur (#12925) //<Nathan Hunzaker>// - **[aa85b0f](react/react@aa85b0fd5)**: Upgrade to Jest 23 (#12894) //<Simen Bekkhus>// - **[61777a7](react/react@61777a78f)**: [scheduler] 3/n Use a linked list instead of map and queue for callback storage (#12893) //<Flarnie Marchan>// - **[e7bd3d5](react/react@e7bd3d59a)**: No longer expose ReactNativeComponentTree (#12904) //<Sebastian Markbåge>// - **[f35d989](react/react@f35d989be)**: TestRenderer warns if flushThrough is passed the wrong params (#12909) //<Brian Vaughn>// - **[5578700](react/react@557870067)**: Record "actual" times for all Fibers within a Profiler tree (alt) (#12910) //<Brian Vaughn>// - **[76e0707](react/react@76e07071a)**: [scheduler] 2/n Adding 'schedule' fixture (#12884) //<Flarnie Marchan>// - **[345e0a7](react/react@345e0a71a)**: Improve tests for 'schedule' module (#12880) //<Flarnie Marchan>// - **[8765d60](react/react@8765d6089)**: Update bundle sizes for 16.4.0 release //<Andrew Clark>// - **[d427a56](react/react@d427a563d)**: Updating package versions for release 16.4.0 //<Andrew Clark>// - **[53852a8](react/react@53852a887)**: add functional components warning about legacy context api (#12892) //<Chang Yan>// - **[fe747a5](react/react@fe747a51c)**: Add React.Timeout to getComponentName (#12890) //<Toru Kobayashi>// - **[c601f7a](react/react@c601f7a64)**: add siblings Timeout components test case (#12862) //<Chang Yan>// - **[7350358](react/react@735035837)**: add legacy context API warning in strict mode (#12849) //<Chang Yan>// - **[e885791](react/react@e88579184)**: Fix a regression that caused us to listen to extra events at the top (#12878) //<Dan Abramov>// - **[7c0aca2](react/react@7c0aca289)**: Rollup freeze: false (#12879) //<Brian Vaughn>// - **[33289b5](react/react@33289b530)**: Tests and fixes for 'timing out' behavior (#12858) //<Flarnie Marchan>// - **[ad27845](react/react@ad27845cc)**: Fix double-firing submit events (#12877) //<Sophie Alpert>// - **[dd5fad2](react/react@dd5fad296)**: Update Flow to 0.70 (#12875) //<Dan Abramov>// - **[1300365](react/react@13003654e)**: Pass "start time" and "commit time" to Profiler callback (#12852) //<Brian Vaughn>// - **[dc3b144](react/react@dc3b144f4)**: Treat Rollup "warnings" as errors (#12868) //<Dan Abramov>// - **[d7b9b49](react/react@d7b9b4921)**: Fix react native example links in README of 'react-reconciler' (#12871) //<Kevin (Kun) "Kassimo" Qian>// - **[9bed4a6](react/react@9bed4a6ae)**: https in reactProdInvariant text (#12869) //<Sophie Alpert>// - **[47b003a](react/react@47b003a82)**: Resolve host configs at build time (#12792) //<Dan Abramov>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions c0fe8d6...ae14317 Reviewed By: bvaughn Differential Revision: D8458731 fbshipit-source-id: afefaa50685d43e70c8ea85c70d2e29dee311cbb
grabbou pushed a commit
that referenced
this pull request
Jun 21, 2018
Summary: This sync includes the following changes: - **[ae14317](react/react@ae14317d6)**: Inline fbjs/lib/emptyFunction (#13054) //<Dan Abramov>// - **[72434a7](react/react@72434a768)**: Remove or inline some fbjs dependencies (#13046) //<Dan Abramov>// - **[64c54ed](react/react@64c54edea)**: Adding movementX and movementY to synthenticMouseEvent fixes#6723 (#9018) //<Jason Williams>// - **[9bd4d1f](react/react@9bd4d1fae)**: Synchronously restart when an error is thrown during async rendering (#13041) //<Andrew Clark>// - **[9bda7b2](react/react@9bda7b28f)**: Suspended high pri work forces lower priority work to expire early (#12965) //<Andrew Clark>// - **[2e75779](react/react@2e7577907)**: Fix incorrect data in compositionend event with Korean IME on IE11 (#10217) (#12563) //<Crux>// - **[bc963f3](react/react@bc963f353)**: setJSResponder in Fabric renderer (#13031) //<Sebastian Markbåge>// - **[051637d](react/react@051637da6)**: Extract Fabric event handlers from canonical props (#13024) //<Sebastian Markbåge>// - **[2a80859](react/react@2a8085980)**: Remove rAF fork (#12980) //<Flarnie Marchan>// - **[e0c7834](react/react@e0c78344e)**: Retry on error if there's lower priority pending work (#12957) //<Andrew Clark>// - **[9725065](react/react@9725065eb)**: Update bundle sizes for 16.4.1 release //<Dan Abramov>// - **[0b87b27](react/react@0b87b2790)**: Updating package versions for release 16.4.1 //<Dan Abramov>// - **[036ae3c](react/react@036ae3c6e)**: Use native event dispatching instead of Simulate or SimulateNative (#13023) //<Philipp Spieß>// - **[945fc1b](react/react@945fc1bfc)**: Call gDSFP with the right state in react-test-render (#13030) //<Rafał Ruciński>// - **[3925301](react/react@392530104)**: Remove feature flag around 'getDerivedStateFromProps' bug fix (#13022) //<Flarnie Marchan>// - **[1594409](react/react@1594409fa)**: Scheduler depends on common packages (#13020) //<Dan Abramov>// - **[d5c1119](react/react@d5c11193e)**: Added production profiling bundle type (#12886) //<Brian Vaughn>// - **[ec60457](react/react@ec60457bc)**: Popping context is O(1) in SSR (#13019) //<Dan Abramov>// - **[30bc8ef](react/react@30bc8ef79)**: Allow multiple root children in test renderer traversal API (#13017) //<Dan Abramov>// - **[d480782](react/react@d480782c4)**: Don’t error when returning an empty Fragment (#12966) //<Philipp Spieß>// - **[4ac6f13](react/react@4ac6f133a)**: Fallback to event.srcElement for IE9 (#12976) //<Nathan Hunzaker>// - **[23be410](react/react@23be4102d)**: Fixed an issue with nested contexts unwinding when server rendering. Issue #12984 (#12985) //<Eric Soderberg>// - **[d0d4280](react/react@d0d428064)**: Remove old reference to inst._wrapperState (#12987) //<Nathan Hunzaker>// - **[c78957e](react/react@c78957eac)**: Fix an SVG focusing crash in IE11 (#12996) //<Jifa Jiang>// - **[bfb12eb](react/react@bfb12ebb5)**: delete a couple of redundant lines in performWorkOnRoot() in ReactFiberScheduler.js (#13003) //<Nathan Quarles>// - **[394b17e](react/react@394b17eed)**: Update custom renderer docs //<Dan Abramov>// - **[188c425](react/react@188c4252a)**: Fix react-dom ReferenceError requestAnimationFrame in non-browser env (#13000) (#13001) //<Ivan Babak>// - **[9cf3733](react/react@9cf3733a9)**: update comment in computeAsyncExpiration() to reflect code (#12994) //<Nathan Quarles>// - **[c5a733e](react/react@c5a733e1e)**: Fix links of docs on the comment (#12795) //<Ende93>// - **[36546b5](react/react@36546b513)**: Set the correct initial value on input range (#12939) //<Maxime Nory>// - **[15767a8](react/react@15767a8f8)**: [scheduler] 5/n Error handling in scheduler (#12920) //<Flarnie Marchan>// - **[3118ed9](react/react@3118ed9d6)**: Expose unstable_interactiveUpdates on ReactDOM (#12943) //<Andrew Clark>// - **[524a743](react/react@524a74331)**: Fix for Flow issues in SimpleCacheProvider (#12942) //<Flarnie Marchan>// - **[ae57b12](react/react@ae57b125c)**: [simple-cache-provider] Use LRU cache eviction (#12851) //<Andrew Clark>// - **[e0a03c1](react/react@e0a03c1b4)**: Extend input type check in selection capabilities (#12062) (#12135) //<Spyros Ioakeimidis>// - **[79a740c](react/react@79a740c6e)**: Rename variables to remove references to 'global' global (#12931) //<Flarnie Marchan>// - **[ff724d3](react/react@ff724d3c2)**: [scheduler] 4/n Allow splitting out `schedule` in fb-www, prepare to fix polyfill issue internally (#12900) //<Flarnie Marchan>// - **[83f76e4](react/react@83f76e4db)**: ForwardRefs supports propTypes (#12911) //<Brian Vaughn>// - **[8aeea5a](react/react@8aeea5afa)**: Do not assign node.value on input creation if no change will occur (#12925) //<Nathan Hunzaker>// - **[aa85b0f](react/react@aa85b0fd5)**: Upgrade to Jest 23 (#12894) //<Simen Bekkhus>// - **[61777a7](react/react@61777a78f)**: [scheduler] 3/n Use a linked list instead of map and queue for callback storage (#12893) //<Flarnie Marchan>// - **[e7bd3d5](react/react@e7bd3d59a)**: No longer expose ReactNativeComponentTree (#12904) //<Sebastian Markbåge>// - **[f35d989](react/react@f35d989be)**: TestRenderer warns if flushThrough is passed the wrong params (#12909) //<Brian Vaughn>// - **[5578700](react/react@557870067)**: Record "actual" times for all Fibers within a Profiler tree (alt) (#12910) //<Brian Vaughn>// - **[76e0707](react/react@76e07071a)**: [scheduler] 2/n Adding 'schedule' fixture (#12884) //<Flarnie Marchan>// - **[345e0a7](react/react@345e0a71a)**: Improve tests for 'schedule' module (#12880) //<Flarnie Marchan>// - **[8765d60](react/react@8765d6089)**: Update bundle sizes for 16.4.0 release //<Andrew Clark>// - **[d427a56](react/react@d427a563d)**: Updating package versions for release 16.4.0 //<Andrew Clark>// - **[53852a8](react/react@53852a887)**: add functional components warning about legacy context api (#12892) //<Chang Yan>// - **[fe747a5](react/react@fe747a51c)**: Add React.Timeout to getComponentName (#12890) //<Toru Kobayashi>// - **[c601f7a](react/react@c601f7a64)**: add siblings Timeout components test case (#12862) //<Chang Yan>// - **[7350358](react/react@735035837)**: add legacy context API warning in strict mode (#12849) //<Chang Yan>// - **[e885791](react/react@e88579184)**: Fix a regression that caused us to listen to extra events at the top (#12878) //<Dan Abramov>// - **[7c0aca2](react/react@7c0aca289)**: Rollup freeze: false (#12879) //<Brian Vaughn>// - **[33289b5](react/react@33289b530)**: Tests and fixes for 'timing out' behavior (#12858) //<Flarnie Marchan>// - **[ad27845](react/react@ad27845cc)**: Fix double-firing submit events (#12877) //<Sophie Alpert>// - **[dd5fad2](react/react@dd5fad296)**: Update Flow to 0.70 (#12875) //<Dan Abramov>// - **[1300365](react/react@13003654e)**: Pass "start time" and "commit time" to Profiler callback (#12852) //<Brian Vaughn>// - **[dc3b144](react/react@dc3b144f4)**: Treat Rollup "warnings" as errors (#12868) //<Dan Abramov>// - **[d7b9b49](react/react@d7b9b4921)**: Fix react native example links in README of 'react-reconciler' (#12871) //<Kevin (Kun) "Kassimo" Qian>// - **[9bed4a6](react/react@9bed4a6ae)**: https in reactProdInvariant text (#12869) //<Sophie Alpert>// - **[47b003a](react/react@47b003a82)**: Resolve host configs at build time (#12792) //<Dan Abramov>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions c0fe8d6...ae14317 Reviewed By: bvaughn Differential Revision: D8458731 fbshipit-source-id: afefaa50685d43e70c8ea85c70d2e29dee311cbb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug with IP detection on Macs that have (1) multiple ethernet interfaces, (2) are using the second or third interface as their primary connection and (3) have extra loopback IPs configured (for example when running OpenVPN, running some Docker configurations or other more exotic applications). In those cases, automatic IP detection will falsely detect the IP as something like
127.94.0.1, which will make it impossible to run debug builds from a physical device.Cause
The underlying network configurations looks something similar to this (irrelevant parts omitted):
In this configuration the packager will currently figure out
127.94.0.1instead of192.168.0.226.Proposed Fix
In addition to the existing filter on
127.0.0.1, also filter out all loopback addresses by adding a grep filter on127.94.0. This PR does exactly that.Tested and found working on the culprit systems as well as various MacBooks.