Skip to content

PushNotificationIOS.requestPermissions won't resolve if no event listeners are attached#13263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterp wants to merge 1 commit into from
Closed

PushNotificationIOS.requestPermissions won't resolve if no event listeners are attached #13263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Libraries/PushNotificationIOS/RCTPushNotificationManager.m
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,6 +142,15 @@ - (void)startObserving
selector:@selector(handleRemoteNotificationReceived:)
name:RCTRemoteNotificationReceived
object:nil];
[self startObservingRegistrationNotifications];
}

- (void)startObservingRegistrationNotifications
{
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(handleRegisterUserNotificationSettings:)
name:RCTRegisterUserNotificationSettings
object:nil];
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(handleRemoteNotificationsRegistered:)
name:RCTRemoteNotificationsRegistered
Expand All@@ -150,10 +159,6 @@ - (void)startObserving
selector:@selector(handleRemoteNotificationRegistrationError:)
name:RCTErrorRemoteNotificationRegistrationFailed
object:nil];
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(handleRegisterUserNotificationSettings:)
name:RCTRegisterUserNotificationSettings
object:nil];
}

- (void)stopObserving
Expand DownExpand Up@@ -319,6 +324,7 @@ - (void)handleRegisterUserNotificationSettings:(NSNotification *)notification
return;
}

[self startObservingRegistrationNotifications];
_requestPermissionsResolveBlock = resolve;

UIUserNotificationType types = UIUserNotificationTypeNone;
Expand Down