Uh oh!
There was an error while loading. Please reload this page.
TabBarIOS tintColor - #1337
Conversation
ericvicenti
commented
May 19, 2015
Lucky number 1337! Can you expand upon the tab bar example code to show this new functionality? |
tsunammis
commented
May 20, 2015
@ericvicenti do you know how launch UIExplorer e2e test directly on my desktop ? I tried some commands cd Examples/UIExplorer
xctool -scheme UIExplorer -sdk iphonesimulator8.1./scripts/e2e-test.sh./runXcodeTests.shBut I can't reproduce the failing test I have to retrieve the new screenshot and put it on the xamples/UIExplorer/UIExplorerTests/ReferenceImages/Examples-UIExplorer-UIExplorerApp/ folder, but I can't launch the test. Anyone knows ? |
ericvicenti
commented
May 20, 2015
Ah, so the snapshot tests can be finicky. Things will look different based on the device in the simulator, 32 vs 64 bit, OS version, etc. Are you re-recording the snapshot on iPhone 5 (32-bit) and iOS 8.x? You should be able to run the tests locally with |
tsunammis
commented
May 21, 2015
Yeah, I record the snapshot with iOS 8.1 and iPhone 5 but I can't specify 32-bit. The difference between my screenshot and the oldest, its the text size, mine is more smaller than the oldest. @ericvicenti Do you know why ? |
tsunammis
commented
May 21, 2015
@ericvicenti it's ok ? I changed the “recordMode” from NO to YES inside the UIExplorerTests, the “reference image” has been updated, and I can’t see my changes on the screenshot, but I see the changes when I run the UIExplorer project on Xcode, do you know why ? And by now, the tests pass but it is bullshit according to me. What is the next steps to merge this feature ? |
tsunammis
commented
May 21, 2015
@nicklockwood Do you have something to add ? |
nicklockwood
commented
May 21, 2015
Running tests on iPhone 5 automatically makes them 32-bit, iPhone 5s and above is 64-bit. I don't know why you wouldn't be seeing the changes in the reference image. That's very strange. |
tsunammis
commented
May 21, 2015
@nicklockwood code updated ;-) Can you try this branch if you see the tab bar in blue on the UIExplorer project ? |
tsunammis
commented
May 23, 2015
@a2@nicklockwood@ericvicenti merging is possible ? |
johanneslumpe
commented
May 27, 2015
This would be nice to get merged! :) |
brentvatne
commented
May 27, 2015
Looks good to me |
tsunammis
commented
May 27, 2015
@brentvatne what is the next step ? This could be merged friday during the time afforded to those things ? -> https://gist.github.com/brentvatne/e1ca1e4beaf0135e3178 |
nicklockwood
commented
May 27, 2015
This was actually merged yesterday. Should be included in the next update. Sorry for the wait! |
brentvatne
commented
May 27, 2015
👍 thanks @nicklockwood! |
brentvatne
commented
May 27, 2015
@tsunammis - looks like that won't be needed 😄 hope you join in on Friday! |
tsunammis
commented
May 27, 2015
@brentvatne thank you !! I hope I will be available friday, what is the timezone ? I'm in Paris. |
Summary: [Origin Pull request](react#961) from [cmcewen](https://github.com/cmcewen) All the work have been done by @cmcewen, I just rebased his work with the master. Closesreact#1337 Github Author: Stan Chollet <stanislas.chollet@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
brentvatne
commented
May 28, 2015
@tsunammis - I'll be around at 10am - 3pm PT 😄 |
* Delete more stuff * Remove some stale looking SDX platform scripts * Remove remnant of `acceptsKeyboardFocus` * Add back some missing newlines
Origin Pull request from cmcewen
All the work have been done by @cmcewen, I just rebased his work with the master.