Skip to content

[npm] Remove unused npm packages and move CI dependency to devDependencies - #13517

Closed
ide wants to merge 1 commit into
react:masterfrom
expo:cleanup-deps
Closed

[npm] Remove unused npm packages and move CI dependency to devDependencies#13517
ide wants to merge 1 commit into
react:masterfrom
expo:cleanup-deps

Conversation

@ide

@ideide commented Apr 15, 2017

Copy link
Copy Markdown
Contributor

There are several npm packages that are no longer used and do not show up when grepping the code base. Also the "async" dependency is used only in CI and should be moved to devDependencies.

Test Plan: Load the UIExplorer. Run Travis CI, Circle CI, and FB internal tests.

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Apr 15, 2017

@hramoshramos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a manual import, and we'll also need to make sure internal tests run. I'm going to import it (without landing).

@facebook-github-botfacebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Apr 27, 2017
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@skevy

skevy commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

@ide this should be either cleaned up or closed, given the recent changes to dependencies with the packager moving.

@ide

ide commented Jun 8, 2017

Copy link
Copy Markdown
ContributorAuthor

Updated this PR. @hramos could you please re-import this when you have a chance to?

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ide
ideforce-pushed the cleanup-deps branch 3 times, most recently from ed32ec1 to caf085fCompareJuly 7, 2017 07:32
@cpojer

Copy link
Copy Markdown
Contributor

This is awesome!

@hramos

Copy link
Copy Markdown
Contributor

I'll take a look at this after #14880 lands.

@hramos
hramos requested a review from ericnakagawa as a code ownerJuly 7, 2017 23:41
…ncies
There are several npm packages that are no longer used and do not show up when grepping the code base. Also the "async" dependency is used only in CI and should be moved to devDependencies.
Test Plan: Load the UIExplorer. Run Travis CI, Circle CI, and FB internal tests.
@pull-bot

Copy link
Copy Markdown
Warnings
⚠️

🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

This PR has been submitted by a core contributor.

Attention: @facebook/react-native

Generated by 🚫 dangerJS

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ide
ide deleted the cleanup-deps branch August 2, 2017 18:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Import StartedThis pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ide@facebook-github-bot@skevy@cpojer@hramos@pull-bot@shergin