Uh oh!
There was an error while loading. Please reload this page.
Fix run-ios when specifying a scheme as cli arg - #13548
Conversation
The cli arg `--scheme` allows you to override the inferred scheme. The runOnDevice command takes this override into account, but run-ios doesn't. This commit fixes this discrepancy.
facebook-github-bot
commented
Apr 17, 2017
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
pesterhazy
commented
Apr 17, 2017
Signed the CA |
facebook-github-bot
commented
Apr 17, 2017
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
pesterhazy
commented
Apr 17, 2017
Don't think the circleci fault is related to my change |
javache
commented
Apr 18, 2017
|
pesterhazy
commented
Apr 19, 2017
@javache, you're right of course. I've updated the PR. |
pesterhazy
commented
Apr 19, 2017
I don't think the CI failure was caused by my update. Maybe rebuild circle? |
facebook-github-bot
commented
Apr 19, 2017
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: The cli arg `--scheme` allows you to override the inferred scheme. The runOnDevice command takes this override into account, but run-ios doesn't. This commit fixes this discrepancy. Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. Currently if a custom scheme is specified, `run-ios` will fail with the following message ``` Error: Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/AwesomeProject.app/Info.plist Print: Entry, ":CFBundleIdentifier", Does Not Exist ``` This PR fixes this. Tested manually from CLI. Closesreact#13548 Differential Revision: D4914531 Pulled By: javache fbshipit-source-id: 071710947e90e6194e0229751e33068565e010b2
Summary: The cli arg `--scheme` allows you to override the inferred scheme. The runOnDevice command takes this override into account, but run-ios doesn't. This commit fixes this discrepancy. Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. Currently if a custom scheme is specified, `run-ios` will fail with the following message ``` Error: Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/AwesomeProject.app/Info.plist Print: Entry, ":CFBundleIdentifier", Does Not Exist ``` This PR fixes this. Tested manually from CLI. Closesreact/react-native#13548 Differential Revision: D4914531 Pulled By: javache fbshipit-source-id: 071710947e90e6194e0229751e33068565e010b2
The cli arg
--schemeallows you to override the inferred scheme.The runOnDevice command takes this override into account, but run-ios
doesn't. This commit fixes this discrepancy.
Thanks for submitting a PR! Please read these instructions carefully:
masterbranch, NOT a "stable" branch.Motivation (required)
Currently if a custom scheme is specified,
run-ioswill fail with the following messageThis PR fixes this.
Test Plan (required)
Tested manually from CLI.