Uh oh!
There was an error while loading. Please reload this page.
Add the license field on package.json - #1409
Closed
dalinaum wants to merge 1 commit into
Closed
Conversation
ide
commented
May 26, 2015
Contributor
jest is unrelated to testing:https://www.npmjs.com/package/jest |
dalinaum
commented
May 26, 2015
ContributorAuthor
Oh. I had a mistake. I thought jest is needed. I have to remove jest on package.json. Thanks @ide |
vjeux
commented
May 28, 2015
Contributor
Sounds good, react has the same https://github.com/facebook/react/blob/master/package.json#L13 |
vjeux
commented
May 28, 2015
Contributor
@facebook-github-bot import |
facebook-github-bot
commented
May 28, 2015
Contributor
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/831340873568138/int_phab to review. |
tadeuzagallo pushed a commit
to tadeuzagallo/react-native
that referenced
this pull request
May 29, 2015
Summary: Add the license field on package.json Closesreact#1409 Github Author: Leonardo YongUk Kim <dalinaum@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
brentvatne
commented
May 29, 2015
Collaborator
This made it into today's sync, closing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the license field on package.json