Skip to content

Fix Travis podspec CI for Cxx bridge - #14100

Closed
javache wants to merge 2 commits into
masterfrom
javache-podspecs
Closed

Fix Travis podspec CI for Cxx bridge#14100
javache wants to merge 2 commits into
masterfrom
javache-podspecs

Conversation

@javache

@javachejavache commented May 22, 2017

Copy link
Copy Markdown
Contributor

Fixed the test script to properly setup our third-party deps and tweaked the third-party specs a bit so they work correctly.

This currently works for projects using static libraries, but fails when using dynamic libraries (--use-libraries)

cc @mhorowitz@alloy

@facebook-github-botfacebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 22, 2017
@javachejavache mentioned this pull request May 23, 2017
Closed
@javache

javache commented May 23, 2017

Copy link
Copy Markdown
ContributorAuthor

The build is stalling in untarring boost, which is also what I saw on my local machine when running this script.

@javachejavache mentioned this pull request May 23, 2017
Closed
@javache
javacheforce-pushed the javache-podspecs branch 2 times, most recently from 121d10d to 3ca7446CompareMay 23, 2017 15:31
ide
ide reviewed May 23, 2017
View reviewed changes
Comment threadthird-party-podspecs/GLog.podspec Outdated
spec.summary = 'Google logging module'
spec.authors = 'Google'

# Keep in sync with ios-configure-glog.sh

@ideideMay 23, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you want to do this, but just to put the idea out there -- since this file is just Ruby code, it can read from ios-configure-glog.sh or some other shared file so that the two don't need to manually be kept in sync.

@javachejavacheMay 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I considered that. I guess if people install them through NPM we should have the same file available locally, but cocoapod's linting procedure may not copy these files over. I'll give it a try.

facebook-github-bot pushed a commit that referenced this pull request May 30, 2017
@javache@facebook-github-bot
Fix some issues with the React podspec for the Cxx bridge
33e2248
Summary:
Trying to fix the RN Travis CI tests
Splitting off from #14100Closes#14132
Reviewed By: ericvicenti
Differential Revision: D5112077
Pulled By: javache
fbshipit-source-id: cf030b927b0f28f2b494471498f1ddb2c0a5c1df
@javachejavache changed the title Fix podspecs for Cxx bridgeFix Travis podspec CI for Cxx bridgeMay 31, 2017
@javachejavache mentioned this pull request Jun 6, 2017
Closed
@javache

javache commented Jul 1, 2017

Copy link
Copy Markdown
ContributorAuthor

Podspec run passes! https://travis-ci.org/facebook/react-native/jobs/248978123

@javache
javacheforce-pushed the javache-podspecs branch 2 times, most recently from c65c8fb to 0f2d052CompareJuly 3, 2017 11:24
@facebook-github-botfacebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 7, 2017
@facebook-github-bot

facebook-github-bot commented Jul 7, 2017

Copy link
Copy Markdown
Contributor

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@javache
javache deleted the javache-podspecs branch July 7, 2017 09:40
ide pushed a commit that referenced this pull request Jul 7, 2017
@javache@ide
Fix Travis podspec CI for Cxx bridge
cc4fada
Summary:
Fixed the test script to properly setup our third-party deps and tweaked the third-party specs a bit so they work correctly.
This currently works for projects using static libraries, but fails when using dynamic libraries (`--use-libraries`)
cc mhorowitz alloy
Closes#14100
Differential Revision: D5380728
Pulled By: javache
fbshipit-source-id: e78b6bd4466ebf2bf30b7e361eff10ec14b36a55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ideideide left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Import StartedThis pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javache@facebook-github-bot@ide@shergin