Uh oh!
There was an error while loading. Please reload this page.
Support for preventing swipe left or swipe right - #14684
Conversation
The primary use case for this is disabling swipe right when using react-navigation's swipe to go back feature.
lprhodes
commented
Jun 22, 2017
I'd appreciate suggestions on how to provide a solid test plan for this...it's a pretty minor change. |
sahrens
left a comment
There was a problem hiding this comment.
This doesn't seem ideal, but if this solves a problem for you it's fine.
facebook-github-bot
commented
Jul 8, 2017
@sahrens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
migueloller
commented
Jul 8, 2017
There is already a way to prevent the "swipe to go back" functionality in React Navigation. See |
lprhodes
commented
Jul 8, 2017
@migueloller That isn't the intention. Swipe to go back should still work when used in conjunction with the experimental swipe-able cells. That's not currently the case. Hold on approval though please. I'd like to double check no further amends were made to this. |
I had fixed this locally but not updated the original pull request, sorry. This commit is working for us in production.
lprhodes
commented
Jul 8, 2017
Summary: I had fixed this locally but hadn't updated the original pull request, sorry. This commit is working for us in production. Closes#14900 Differential Revision: D5539787 Pulled By: hramos fbshipit-source-id: 6c826ada4a7f36607c65508ced6c9dce32002f74
Summary: I had fixed this locally but hadn't updated the original pull request, sorry. This commit is working for us in production. Closes#14900 Differential Revision: D5539787 Pulled By: hramos fbshipit-source-id: 6c826ada4a7f36607c65508ced6c9dce32002f74
The primary use case for this is disabling swipe right when using react-navigation's swipe to go back feature.