Skip to content

[Packager] Allow user to specify a custom transformer file - #1497

Closed
johanneslumpe wants to merge 5 commits into
react:masterfrom
johanneslumpe:patch-2
Closed

[Packager] Allow user to specify a custom transformer file#1497
johanneslumpe wants to merge 5 commits into
react:masterfrom
johanneslumpe:patch-2

Conversation

@johanneslumpe

Copy link
Copy Markdown
Contributor

This is an edited re-submission of #1458 because I'm stupid.

@facebook-github-botfacebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 3, 2015
Comment threadpackager/packager.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only available on very recent node (0.12) and io.js versions. What's the supported version for the packager?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's odd. If we have to support older version, we might add

path.resolve(transformerPath) === path.normalize(transformerPath)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to support v0.10 (after all jest doesn't run on v0.12 yet). We have a package installed for this absolute-path

@amasad

Copy link
Copy Markdown
Contributor

Just fix the absolute-path thing and this should be good to go.

@johanneslumpe

Copy link
Copy Markdown
ContributorAuthor

@amasad done!

@amasad

Copy link
Copy Markdown
Contributor

Great! Will do pull it. It'd be nice to add some docs to that as well :) 💃

@johanneslumpe

Copy link
Copy Markdown
ContributorAuthor

@amasad are those docs fine?

Comment threaddocs/JavaScriptEnvironment.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really have to wait on all interpreters. We can just end the sentence at by allowing you to use new JavaScript language features.

@amasad

Copy link
Copy Markdown
Contributor

Sorry for the late reply. Just a few nits on the docs

@ideide mentioned this pull request Jun 16, 2015
@johanneslumpe

Copy link
Copy Markdown
ContributorAuthor

@amasad updated the docs. I actually didn't write those texts, but they're changed the way you wanted now :)

@a2a2 closed this in 1461e4aJul 2, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@johanneslumpe@amasad@sebmck@brentvatne@facebook-github-bot