Uh oh!
There was an error while loading. Please reload this page.
Fix format specifier used in RCTUIManager - #15414
Conversation
Here, `reactTag` is an `NSNumber *` which uses `%@` as the format specifier. Newer versions of clang can warn or error on this. This change prevents that from happening.
pull-bot
commented
Aug 8, 2017
javache
commented
Aug 8, 2017
Thanks! FYI, you can just submit these internally too. |
facebook-github-bot
commented
Aug 8, 2017
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Aug 9, 2017
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
shergin
commented
Aug 9, 2017
@kastiglione Uh, really? I believe |
kastiglione
commented
Aug 9, 2017
@shergin sounds like you agree with this change from |
kastiglione
commented
Aug 9, 2017
@javache why did this fail? |
javache
commented
Aug 9, 2017
Just some internal flakiness. It's been merged now. |
shergin
commented
Aug 9, 2017
@kastiglione Yeah, I misread the diff... Sorry for the mess. |
Here,
reactTagis anNSNumber *which uses%@as the format specifier. Newer versions of clang can warn or error on this. This change prevents that from happening.See also #15402
Test Plan
Local builds with clang 5.