Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 25.2k
[tvOS] onPress animation with magnification#15455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
4aed47db0c6ec4812e6acda967ca6990bdc94ea7c87560ce0e3688b5b9a1c4243cac24eb7cbe41b52876619067fba13cbe19904676a18f99c26f9923c4489aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -15,6 +15,7 @@ | ||
| const ColorPropType = require('ColorPropType'); | ||
| const NativeMethodsMixin = require('NativeMethodsMixin'); | ||
| const PropTypes = require('prop-types'); | ||
| const Platform = require('Platform'); | ||
| const React = require('React'); | ||
| const ReactNativeViewAttributes = require('ReactNativeViewAttributes'); | ||
| const StyleSheet = require('StyleSheet'); | ||
| @@ -174,6 +175,9 @@ const TouchableHighlight = createReactClass({ | ||
| * shiftDistanceY: Defaults to 2.0. | ||
| * tiltAngle: Defaults to 0.05. | ||
| * magnification: Defaults to 1.0. | ||
| * pressMagnification: Defaults to 1.0. | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto. These will need to be copied over to the | ||
| * pressDuration: Defaults to 0.3. | ||
| * pressDelay: Defaults to 0.0. | ||
| * | ||
| * @platform ios | ||
| */ | ||
| @@ -232,11 +236,13 @@ const TouchableHighlight = createReactClass({ | ||
| touchableHandlePress: function(e: PressEvent) { | ||
| clearTimeout(this._hideTimeout); | ||
| this._showUnderlay(); | ||
| this._hideTimeout = setTimeout( | ||
| this._hideUnderlay, | ||
| this.props.delayPressOut, | ||
| ); | ||
| if (!Platform.isTVOS) { | ||
| this._showUnderlay(); | ||
| this._hideTimeout = setTimeout( | ||
| this._hideUnderlay, | ||
| this.props.delayPressOut, | ||
| ); | ||
| } | ||
| this.props.onPress && this.props.onPress(e); | ||
| }, | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's document these in https://github.com/facebook/react-native-website as well, since those are the docs that are displayed on the website itself.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the information @hramos I've created a pull request here react/react-native-website#176