Skip to content

Make prospective syntax compatible - #15510

Closed
jaychsu wants to merge 2 commits into
react:masterfrom
jaychsu:master
Closed

Make prospective syntax compatible#15510
jaychsu wants to merge 2 commits into
react:masterfrom
jaychsu:master

Conversation

@jaychsu

@jaychsujaychsu commented Aug 16, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Problem

Can't run RNTester app and got the error below:

image

Resolution

Make prospective syntax(trailing commas in function parameter lists and calls, supported in ES8) compatible.

Test Plan

If correct, the RNTester can be started.

@facebook-github-bot

facebook-github-bot commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-botfacebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 16, 2017
@facebook-github-bot

facebook-github-bot commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@elicwhite

elicwhite commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

Looks related to #15517 and #15513

@facebook-github-botfacebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Aug 16, 2017
@facebook-github-bot

facebook-github-bot commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@elicwhite

elicwhite commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

Thanks for contributing!

@jaychsu

jaychsu commented Aug 16, 2017

Copy link
Copy Markdown
ContributorAuthor

you are welcome ;)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elicwhiteelicwhiteelicwhite approved these changes

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Import StartedThis pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaychsu@facebook-github-bot@elicwhite