Uh oh!
There was an error while loading. Please reload this page.
Add snapToInterval support for Android ScrollView - #15667
Conversation
a76a35d to
25aac4fComparesigvef
commented
Aug 26, 2017
(fwiw, the builds are failing because master is red atm) |
henrikra
commented
Aug 27, 2017
I have already done PR about this #15297 |
sigvef
commented
Aug 27, 2017
Nice! Hope this means that we can get this feature soon :) |
25aac4f to
0d4ed33Compare0d4ed33 to
2e41b46Comparefacebook-github-bot
commented
Oct 19, 2017
@sigvef I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
ghost
commented
Dec 17, 2017
Hey! I'm willing to do anything at all to help along this PR from August being merged before 2017 is gone forever and 2018 rolls around. Please let me know if there's anything I can do to help. |
sigvef
commented
Feb 7, 2018
This feature has now been implemented in ddd65f1, and landed in RN 0.53. |
This pull request adds Android support for
snapToIntervalin theScrollViewcomponent (it is already implemented for iOS). I need it for a project, so I will be responsive and follow up on any comments on this pull request :)Test Plan
The code change is pretty minimal, so it should be easy to reason about. I made a quick bare-bones test project with
react-native initand tested it in an android emulator.The test project code:
A video of it running:
