Uh oh!
There was an error while loading. Please reload this page.
Refactor how symlinks are discovered in local-cli, support scoped modules - #15776
Refactor how symlinks are discovered in local-cli, support scoped modules#15776skevy wants to merge 1 commit into
Conversation
| path.join(getProjectPath(), 'node_modules'), | ||
| roots | ||
| ) | ||
| const resolveSymlinksForRoots = roots => |
There was a problem hiding this comment.
Adds support for resolving symlinks in multiple roots, rather than just the project path
| @@ -0,0 +1,368 @@ | |||
| /** | |||
There was a problem hiding this comment.
This is a copy of the fs mock from metro-bundler. Adds exists/existsSync + readlink/readlinkSync support.
@facebook-github-bot label Core Team @facebook-github-bot large-pr Generated by 🚫 dangerJS |
skevy
commented
Sep 3, 2017
Flow error from Circle is unrelated. Was introduced 2 days ago here: |
rafeca
commented
Sep 3, 2017
@skevy tomorrow we are going to release a new version of |
jeanlauliac
commented
Sep 5, 2017
I'll try to make progress on that today/tomorrow |
This PR refactors the symlink finding logic in order to support nested symlinked modules as well as scoped NPM modules.
9690dad to
be2ffa9Compareskevy
commented
Sep 12, 2017
Hi @jeanlauliac any updates here? |
facebook-github-bot
commented
Sep 13, 2017
@jeanlauliac has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jeanlauliac
left a comment
There was a problem hiding this comment.
Yup looks good to me, thank you! I'll try to merge today. Sorry for the delay, I'll try to be more reactive on PRs here.
| console.log( | ||
| `Scanning folders for symlinks in ${nodeModuleRoot} (${timeEnd - | ||
| timeStart}ms)`, |
There was a problem hiding this comment.
Normally we'd want to go through a reporter for any output, not print to the console directly. But I'm okay with shipping it like so and we can improve later :)
@skevy lemme know if that looks all good 😄 |
…ules Summary: This PR refactors the symlink finding logic in local-cli in order to support nested symlinked modules as well as symlinked scoped NPM modules. Run tests, or try project with `npm link`'ed or `yarn link`'ed dependencies. Closes#15776 Reviewed By: cpojer Differential Revision: D5823008 Pulled By: jeanlauliac fbshipit-source-id: f2daeceef37bed2f8a136a0a5918730f9832884c
…ules Summary: This PR refactors the symlink finding logic in local-cli in order to support nested symlinked modules as well as symlinked scoped NPM modules. Run tests, or try project with `npm link`'ed or `yarn link`'ed dependencies. Closesreact/react-native#15776 Reviewed By: cpojer Differential Revision: D5823008 Pulled By: jeanlauliac fbshipit-source-id: f2daeceef37bed2f8a136a0a5918730f9832884c
This PR refactors the symlink finding logic in local-cli in order to support nested symlinked modules as well as symlinked scoped NPM modules.
Test Plan
Run tests, or try project with
npm link'ed oryarn link'ed dependencies.