Uh oh!
There was an error while loading. Please reload this page.
fix ItemSeparatorComponent position in horizontal and inverted mode - #15865
Closed
VahidBo wants to merge 3 commits into
Closed
fix ItemSeparatorComponent position in horizontal and inverted mode#15865VahidBo wants to merge 3 commits into
VahidBo wants to merge 3 commits into
Conversation
hramos
commented
Sep 8, 2017
Contributor
Thanks for the pull request! This is a great first PR. |
facebook-github-bot
commented
Sep 8, 2017
Contributor
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
VahidBo
commented
Sep 9, 2017
ContributorAuthor
@hramos Thank you very much. |
I'm still facing this Issue, I'm not getting Space between Images |
VahidBo
commented
Sep 10, 2017
ContributorAuthor
@chiranjeevisaride It's not released yet. |
gautan
commented
Sep 10, 2017
When are you planning to release? |
gautan
commented
Sep 10, 2017
@VahidBo When are you planning to release? |
djhr
commented
Oct 11, 2017
@hramos when is it expected to have a release with this fix? |
hramos
commented
Oct 11, 2017
Contributor
stokesbga
commented
Dec 31, 2018
It looks like this doesnt work on sectionlist, v57.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
There's a positioning bug in
VirtualizedListwhenItemSeparatorComponentis defined for a list in horizontal or inverted mode. And also we face this bug inFlatList, because it is usingVirtualizedListto render lists.This commit will fix the #15777.
Before fix:
Test Plan
I ran this code with all possible values of
horizontalandinvertedprops inFlatListandVirtualizedListand the results of each run was as below:After fix bug: