Uh oh!
There was an error while loading. Please reload this page.
Add prettier config, format script and reformat files - #16176
Closed
janicduplessis wants to merge 3 commits into
Closed
Add prettier config, format script and reformat files#16176janicduplessis wants to merge 3 commits into
janicduplessis wants to merge 3 commits into
Conversation
shergin
commented
Oct 10, 2017
Contributor
@janicduplessis Conflicts? |
janicduplessis
commented
Oct 10, 2017
ContributorAuthor
@shergin Fixed |
janicduplessis
commented
Nov 5, 2017
ContributorAuthor
ping @shergin :) |
pull-bot
commented
Nov 5, 2017
@facebook-github-bot label Needs more information @facebook-github-bot label Core Team Attention: @hramos Generated by 🚫 dangerJS |
facebook-github-bot
approved these changes
Nov 7, 2017
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cdlewis pushed a commit
to cdlewis/react-native
that referenced
this pull request
Nov 19, 2017
Summary: Prettier 1.7.0 has config file + pragma support so this works really well with the current prettier usage. Also added a prettier script to run it (taken mostly from the relay repo) and ran it which caused 1 files to change (probably wasn't updated when upgrading prettier to 1.7.0). **Test plan** Made sure flow still checked Run 'yarn prettier', should format only files with `format` using the config in package.json. Closesreact#16176 Differential Revision: D6256899 Pulled By: shergin fbshipit-source-id: 646d90c15db8032b7b551da228d26d370babf125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier 1.7.0 has config file + pragma support so this works really well with the current prettier usage. Also added a prettier script to run it (taken mostly from the relay repo) and ran it which caused 1 files to change (probably wasn't updated when upgrading prettier to 1.7.0).
Test plan
Made sure flow still checked
Run 'yarn prettier', should format only files with
@formatusing the config in package.json.