Uh oh!
There was an error while loading. Please reload this page.
Use UnimplementedView for CheckBox on iOS - #16211
Closed
timwangdev wants to merge 2 commits into
Closed
Conversation
janicduplessis
commented
Oct 7, 2017
Contributor
@facebook-github-bot shipit |
facebook-github-bot
approved these changes
Oct 7, 2017
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckBoxcomponent was introduced in v0.49.0 and not implemented on iOS.Users who are trying to use
CheckBoxon iOS will get a warning thatWe should declare in the document that this component is Android only and use
UnimplementedViewfor iOS.Test Plan
react-native initnew project<Checkbox />after welcome text inApp.js