Uh oh!
There was an error while loading. Please reload this page.
fix(docs): fixing wrong module name in the example of "Integration with Existing Apps" page - #16675
fix(docs): fixing wrong module name in the example of "Integration with Existing Apps" page#16675husky-dev wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Nov 4, 2017
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
pull-bot
commented
Nov 4, 2017
@facebook-github-bot label Documentation Attention: @hramos Generated by 🚫 dangerJS |
facebook-github-bot
commented
Nov 4, 2017
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
janicduplessis
commented
Nov 4, 2017
Thanks for the fix! @facebook-github-bot shipit |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…th Existing Apps" page Summary: The current example of `Objective-C/Swift` component will not work cos of wrong module name in the example. If change `MyReactNativeApp` to the `RNHighScores` everything starts working. [DOCS] [BUGFIX] [IntegrationWithExistingApps.md] - Wrong module name in the example. Closesreact#16675 Differential Revision: D6241675 Pulled By: hramos fbshipit-source-id: d1ce8764399c4589d99060fba726aae0a379f183
Motivation
The current example of
Objective-C/Swiftcomponent will not work cos of wrong module name in the example. If changeMyReactNativeAppto theRNHighScoreseverything starts working.Release Notes
[DOCS] [BUGFIX] [IntegrationWithExistingApps.md] - Wrong module name in the example.