Skip to content

[SwipeableFlatList] Fix #16685, fix opening rows doesn't close on swipe left a new row. #17668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zongwan wants to merge 2 commits into from
Closed

[SwipeableFlatList] Fix #16685, fix opening rows doesn't close on swipe left a new row. #17668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7435862
fix #16685
zongwan Jan 19, 2018
3b8cbf8
Merge branch 'master' into fix-SwipeableFlatList-onOpen
zongwan Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Libraries/Experimental/SwipeableRow/SwipeableFlatList.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const FlatList = require('FlatList');
// TODO: Make this $ReadOnly and Exact. Will require doing the same to the props in
// Libraries/Lists/*
type SwipableListProps = {
preventSwipeRight: boolean,
/**
* To alert the user that swiping is possible, the first row can bounce
* on component mount.
Expand DownExpand Up@@ -66,6 +67,7 @@ class SwipeableFlatList<ItemT> extends React.Component<Props<ItemT>, State> {

static defaultProps = {
...FlatList.defaultProps,
preventSwipeRight: false,
bounceFirstRowOnMount: true,
renderQuickActions: () => null,
};
Expand All@@ -88,7 +90,7 @@ class SwipeableFlatList<ItemT> extends React.Component<Props<ItemT>, State> {
}}
onScroll={this._onScroll}
renderItem={this._renderItem}
extraData={this.state}
extraData={this.state.openRowKey}
/>
);
}
Expand DownExpand Up@@ -121,6 +123,7 @@ class SwipeableFlatList<ItemT> extends React.Component<Props<ItemT>, State> {

return (
<SwipeableRow
preventSwipeRight={this.props.preventSwipeRight}
slideoutView={slideoutView}
isOpen={key === this.state.openRowKey}
maxSwipeDistance={this._getMaxSwipeDistance(info)}
Expand Down