[Android] Fix: setSelection methods is always returned.

[jainkuniya]

Motivation

Because mMostRecentEventCount < mNativeEventCount is always true as mMostRecentEventCount is not updated.

So determine whether text is set or not from getting current text. Also handle out of bound selection.

Test Plan

Use this component to test with & without this PR

Before this PR, on clicking Button, nothing will happen.
On this PR: text will be selected starting from 0 and ending at 3. (Just for testing I have barcoded start & end value)
Just created a component to test (below).

/* @flow */
import React, { PureComponent } from 'react';
import { View, TextInput, StyleSheet, TouchableHighlight, Text } from 'react-native';
const componentStyles = StyleSheet.create({
input: {
flex: 1,
},
button: {
//position: 'absolute',
right: 0,
alignItems: 'center',
padding: 10,
},
buttonText: {
color: '#000',
},
row: {
flexDirection: 'row',
justifyContent: 'space-between',
},
});
export default class PasswordInput extends PureComponent<Props, State> {
props: Props;
state: State;
state = {
selection: { start: 0, end: 0 },
};
handleSelectionChange = event => {
const { selection } = event.nativeEvent;
this.setState({
selection,
});
};
render() {
const { selection } = this.state;
return (
<View>
<View style={componentStyles.row}>
<TextInput
style={[componentStyles.input]}
placeholder={'Start typing here'}
placeholderTextColor={'green'}
autoCorrect={false}
autoCapitalize="none"
selection={selection}
onSelectionChange={event => this.handleSelectionChange(event)}
/>
</View>
<TouchableHighlight
style={componentStyles.button}
onPress={() => this.setState({ selection: { start: 0, end: 3 } })}
>
<Text style={componentStyles.buttonText}>
{'Selection (Click me to select text starting from 0 to 3 in above textInput)'}
</Text>
</TouchableHighlight>
</View>
);
}
}

Current behaviour

This PR

Release Notes

[ANDROID] [BUGFIX] [TextInput] Fix: setSelection methods is always returned.

[pull-bot]

	Warnings
⚠️	📋 Test Plan - This PR appears to be missing a Test Plan.

@facebook-github-bot label Needs more information

@facebook-github-bot label Android

Generated by 🚫 dangerJS

[jainkuniya]

Thanks! @facebook-open-source-bot I have updated and included Test Plan. 👍 :)

[jainkuniya]

hi @janicduplessis please review this PR too. :)
#17851 is not affective until this issue is solved. :)

[shergin]

How removing mMostRecentEventCount can fix the problem which mMostRecentEventCount is supposed to address?

[jainkuniya]

I tested this and it worked. So I thought it might be the solution but later I got another solution which is more solid #17990. We can close this after #17990 gets resolved. :)

[facebook-github-bot]

@jainkuniya do you have any updates for this pull request? It's been a while since the last update so wanted to check in and see if you've looked at the requested changes.

[cpojer]

Yeah this doesn't seem like the solution we are looking for here. I'm gonna close this PR.

[jainkuniya]

Hey @cpojer can you please also review #17990