Uh oh!
There was an error while loading. Please reload this page.
Revert "Better Android Gradle Plugin 3.x integration" - #18189
Revert "Better Android Gradle Plugin 3.x integration"#18189janicduplessis wants to merge 1 commit into
Conversation
This reverts commit d16ff3b.
janicduplessis
commented
Mar 5, 2018
@CFKevinRef If you can find a way that also works with gradle 2.14.1 it would be great. Otherwise I think we'll have to hold on a bit before relanding this. |
pull-bot
commented
Mar 5, 2018
Generated by 🚫 dangerJS |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
CFKevinRef
commented
Mar 5, 2018
Not a problem, I do have an idea but will be a few days before I can get back to this. Thanks for the heads up! |
janicduplessis
commented
Mar 5, 2018
@CFKevinRef Thanks! If this is a blocker for anyone it is possible to copy the content of the react.gradle file inside your project and change the plugin apply path to point to that instead of the one under node_modules/react-native. |
This reverts commit d16ff3b.
Motivation
Currently breaks with the gradle version used by RN, I think there has been some work to update that to a more recent one but for now I think we should just revert it.
It errors with:
Test Plan
Tested that RN tester now builds when using the right react.gradle (#18188)
Release Notes
[ ANDROID ] [ BUGFIX ] [ react.gradle ] - REVERT "Support Android Gradle Plugin 3.x and AAPT2"
[ ANDROID ] [ FEATURE ] [ react.gradle ] - REVERT "Expose the bundling task and its outputs via ext properties"