Skip to content

[io.js] Print a warning message if the user is not on io.js 2.x - #1824

Closed
ide wants to merge 1 commit into
react:masterfrom
ide:iojs-packager-banner
Closed

[io.js] Print a warning message if the user is not on io.js 2.x#1824
ide wants to merge 1 commit into
react:masterfrom
ide:iojs-packager-banner

Conversation

@ide

@ideide commented Jul 1, 2015

Copy link
Copy Markdown
Contributor

Detects if the user is on Node or io.js 1.x and prints a banner explaining how to upgrade. We probably should link to more detailed upgrade docs so this is just a start.

I also added a function to format banners that is kind of useful.

Addresses part of #1737

packager-banner

@ide
ideforce-pushed the iojs-packager-banner branch from 7ddc624 to d1a1e63CompareJuly 1, 2015 03:39
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2015
@prathamesh-sonpatki

Copy link
Copy Markdown
Contributor

@ide I just tried

brew link iojs --force

But it gives following error for me

$ brew link iojs --force
Linking /usr/local/Cellar/iojs/2.3.1... Error: Could not symlink bin/node
Target /usr/local/bin/node
is a symlink belonging to node. You can unlink it:
brew unlink node
To force the link and overwrite all conflicting files:
brew link --overwrite iojs
To list all files that would be deleted:
brew link --overwrite --dry-run iojs

I think we should mention

brew unlink node

also.

@ide
ideforce-pushed the iojs-packager-banner branch from d1a1e63 to 0b16ca2CompareJuly 1, 2015 04:07
@ide

ide commented Jul 1, 2015

Copy link
Copy Markdown
ContributorAuthor

@prathamesh-sonpatki good catch. the instructions now include brew unlink node; brew install iojs && brew ln iojs --force.

@amasad

Copy link
Copy Markdown
Contributor

awesome.

@ide
ideforce-pushed the iojs-packager-banner branch 2 times, most recently from dda3d28 to 791ffcfCompareJuly 2, 2015 18:51
Detects if the user is on Node or io.js 1.x and prints a banner explaining how to upgrade. We probably should link to more detailed upgrade docs so this is just a start.
@ide

ide commented Jul 2, 2015

Copy link
Copy Markdown
ContributorAuthor

Removed the bit about "next release" from the message since the jest upgrade and io.js support already landed. Moving fast!

@ide

ide commented Jul 7, 2015

Copy link
Copy Markdown
ContributorAuthor

@amasad could I get an update on when this will be merged? I'd like to include it with 0.8.0-rc (checklist here #1864) to pre-emptively answer issues people might encounter if they're using Node.

@ide

ide commented Jul 9, 2015

Copy link
Copy Markdown
ContributorAuthor

@nicklockwood could you help merge this in before we cut 0.8.0-rc? This is the last commit I'd like to include in the RC and the rest of the items on #1864's checklist can wait for 0.8.0-rc.2.

@nicklockwood

Copy link
Copy Markdown
Contributor

@ide, I don't understand the JS side of the platform well enough to judge the implications of this. Maybe @vjeux or @tadeuzagallo can weigh in?

@tadeuzagallo

Copy link
Copy Markdown
Contributor

LGTM

@facebook-github-bot import

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/120269048309122/int_phab to review.

@ideide closed this in 40a0431Jul 10, 2015
@ide

ide commented Jul 10, 2015

Copy link
Copy Markdown
ContributorAuthor

Thanks guys! Ready to release 0.8.0-rc very soon!

@ide
ide deleted the iojs-packager-banner branch July 10, 2015 18:43
cpojer pushed a commit to react/metro that referenced this pull request Jan 26, 2017
Summary:
Detects if the user is on Node or io.js 1.x and prints a banner explaining how to upgrade. We probably should link to more detailed upgrade docs so this is just a start.
I also added a function to format banners that is kind of useful.
Addresses part of #1737
![packager-banner](https://cloud.githubusercontent.com/assets/379606/8447050/ad615402-1f67-11e5-8c02-ece5f7488135.png)
Closesreact/react-native#1824
Github Author: James Ide <ide@jameside.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ide@prathamesh-sonpatki@amasad@nicklockwood@tadeuzagallo@facebook-github-bot