Skip to content

Fix #18272 TextInput.setNativeProps({text: ''}) to work#18278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
magicien wants to merge 5 commits into from
+15 −0
Closed

Fix #18272 TextInput.setNativeProps({text: ''}) to work #18278

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d8e3c7
Add text property to RCTBaseTextInputView
magicien Mar 8, 2018
01440a8
Reapply attributes of NSAttributedString on the setText method
reyalpsirc Mar 13, 2018
d7fac1e
Merge pull request #1 from reyalpsirc/patch-2
magicien Mar 13, 2018
1dcb876
Revise: change "text" property handling
magicien Mar 19, 2018
a374a6a
Revise: Update setText func of RCTBaseTextInputShadowView
magicien Aug 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Libraries/Text/TextInput/RCTBaseTextInputShadowView.m
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ @implementation RCTBaseTextInputShadowView
NSAttributedString *_Nullable _localAttributedText;
CGSize _previousContentSize;

NSString *_text;
NSTextStorage *_textStorage;
NSTextContainer *_textContainer;
NSLayoutManager *_layoutManager;
Expand DownExpand Up@@ -101,6 +102,20 @@ - (void)invalidateContentSize
});
}

- (NSString *)text
{
return _text;
}

- (void)setText:(NSString *)text
{
_text = text;
// Clear `_previousAttributedText` to notify the view about the change
// when `text` native prop is set.
_previousAttributedText = nil;
[self dirtyLayout];
}

#pragma mark - RCTUIManagerObserver

- (void)uiManagerWillPerformMounting
Expand Down