Uh oh!
There was an error while loading. Please reload this page.
Fix wrong root path in RNTester gradle config - #18553
Closed
sunnylqm wants to merge 1 commit into
Closed
Conversation
pull-bot
commented
Mar 25, 2018
Generated by 🚫 dangerJS |
janicduplessis
commented
Mar 25, 2018
Contributor
👍 @facebook-github-bot shipit |
janicduplessis
commented
Mar 30, 2018
Contributor
@facebook-github-bot shipit |
Contributor
Hey, it looks like we're hitting a bug where @facebook-github-bot can make regular comments but cannot make review comments on this pull request (which is interfering with our ability to import this PR). @sunnylqm: is it possible that you've blocked the @facebook-github-bot user? |
sunnylqm
commented
Apr 4, 2018
ContributorAuthor
@yns88 That's right! Just unblocked. It annoyed me a lot before. 🤣 |
facebook-github-bot
approved these changes
Apr 4, 2018
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
campsafari pushed a commit
to exozet/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Currrent(0.54-stable) root path in RNTester gradle config would cause a failure when trying to compile a release version for RNTester: ``` module.js:545 throw err; ^ Error: Cannot find module ’TheParentDirectoryOfCurrentRepo/local-cli/cli.js' at Function.Module._resolveFilename (module.js:543:15) at Function.Module._load (module.js:470:25) at Function.Module.runMain (module.js:690:10) at startup (bootstrap_node.js:194:16) at bootstrap_node.js:666:3 :RNTester:android:app:bundleReleaseJsAndAssets FAILED ``` [ANDROID] [INTERNAL] [RNTester] - Fix wrong root path in RNTester gradle config Closesreact#18553 Differential Revision: D7488301 Pulled By: mdvacca fbshipit-source-id: b49a01820957eb77daeca9c0949f662b668f2bd1
rozele pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 17, 2018
Summary: Currrent(0.54-stable) root path in RNTester gradle config would cause a failure when trying to compile a release version for RNTester: ``` module.js:545 throw err; ^ Error: Cannot find module ’TheParentDirectoryOfCurrentRepo/local-cli/cli.js' at Function.Module._resolveFilename (module.js:543:15) at Function.Module._load (module.js:470:25) at Function.Module.runMain (module.js:690:10) at startup (bootstrap_node.js:194:16) at bootstrap_node.js:666:3 :RNTester:android:app:bundleReleaseJsAndAssets FAILED ``` [ANDROID] [INTERNAL] [RNTester] - Fix wrong root path in RNTester gradle config Closesreact/react-native#18553 Differential Revision: D7488301 Pulled By: mdvacca fbshipit-source-id: b49a01820957eb77daeca9c0949f662b668f2bd1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currrent(0.54-stable) root path in RNTester gradle config would cause a failure when trying to compile a release version for RNTester:
Release Notes
[ANDROID] [INTERNAL] [RNTester] - Fix wrong root path in RNTester gradle config