Skip to content

Add snapshot tests. - #195

Closed
sahrens wants to merge 1 commit into
react:masterfrom
sahrens:snapshotTests
Closed

Add snapshot tests.#195
sahrens wants to merge 1 commit into
react:masterfrom
sahrens:snapshotTests

Conversation

@sahrens

Copy link
Copy Markdown
Contributor

Update

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're one commit behind fyi

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just rebased, which also broke some stuff...updated.

- [ReactNative] Add snapshot tests for examples | Spencer Ahrens
@arasmussen
arasmussenforce-pushed the master branch 5 times, most recently from 9b61be2 to 41453a5CompareMarch 26, 2015 02:57
@sahrens

Copy link
Copy Markdown
ContributorAuthor

Merged internally.

@sahrenssahrens closed this Mar 31, 2015
jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
vzaidman added a commit to vzaidman/react-native that referenced this pull request Jul 23, 2025
Summary:
Changelog: [Internal] - Update `react-native/debugger-frontend` from 8dc0d5b...a7e4f59
Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](react/react-native-devtools-frontend@8dc0d5b...a7e4f59).
### Changelog
[General][Fixed] fixed stack trace parsing failure for certain frames that are special to Hermes that do not exist in V8. | Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [a7e4f5967](react/react-native-devtools-frontend@a7e4f5967) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-23T17:04:33+01:00 | [allow parsing special hermes eval stack trace frames (react#196)](react/react-native-devtools-frontend@a7e4f5967) |
| [12ae91ad4](react/react-native-devtools-frontend@12ae91ad4) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-23T16:37:55+01:00 | [allow parsing stack traces that end with "skipping x frames" (react#195)](react/react-native-devtools-frontend@12ae91ad4) |
| [875a31a90](react/react-native-devtools-frontend@875a31a90) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-15T13:45:16+01:00 | [fixed general contribution guide and added meta contribution guide in pr template (react#194)](react/react-native-devtools-frontend@875a31a90) |
Differential Revision: D78817268
facebook-github-bot pushed a commit that referenced this pull request Jul 23, 2025
Summary:
Pull Request resolved: #52793
Changelog: [Internal] - Update `react-native/debugger-frontend` from 8dc0d5b...a7e4f59
Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](react/react-native-devtools-frontend@8dc0d5b...a7e4f59).
### Changelog
[General][Fixed] fixed stack trace parsing failure for certain frames that are special to Hermes that do not exist in V8.
| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [a7e4f5967](react/react-native-devtools-frontend@a7e4f5967) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-23T17:04:33+01:00 | [allow parsing special hermes eval stack trace frames (#196)](react/react-native-devtools-frontend@a7e4f5967) |
| [12ae91ad4](react/react-native-devtools-frontend@12ae91ad4) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-23T16:37:55+01:00 | [allow parsing stack traces that end with "skipping x frames" (#195)](react/react-native-devtools-frontend@12ae91ad4) |
| [875a31a90](react/react-native-devtools-frontend@875a31a90) | Vitali Zaidman (vzaidman@gmail.com) | 2025-07-15T13:45:16+01:00 | [fixed general contribution guide and added meta contribution guide in pr template (#194)](react/react-native-devtools-frontend@875a31a90) |
Reviewed By: huntie
Differential Revision: D78817268
fbshipit-source-id: 7e266041b3df7ecbcded6e57cb51bd4647dc835d
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sahrens@vjeux