Uh oh!
There was an error while loading. Please reload this page.
Fix ReactImagePropertyTest SoLoader failures - #19607
Closed
AndrewJack wants to merge 1 commit into
Closed
Conversation
AndrewJack
commented
Jun 7, 2018
ContributorAuthor
Looks like this fixes the final test_android failure @hramos |
hramos
commented
Jun 7, 2018
Contributor
You're a hero, @AndrewJack |
facebook-github-bot
approved these changes
Jun 7, 2018
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
marafat added a commit
to plexinc/fb-react-native
that referenced
this pull request
Jun 8, 2018
* master: Fix NullPointerException when emiting event using UIManagerModule Fixed concurrency issue in remote debugger Fix ReactImagePropertyTest SoLoader failures (react#19607) Remove unused include. (react#19548) Update Danger token (react#19606) Modified deepFreezeAndThrowOnMutationInDev to use Object.prototype.ha… (react#19598) Change error message on interpolation (react#19571) Bump Prettier to 1.13.4 on xplat Fix/security issues (react#19373) Add open source Flow declaration for Metro module Use correct library reference for libfishhook.a in RCTWebSocket (react#19579) Enable proguard for Fabric in release builds Fix events not working after closing and navigating back to Fabric screen in FB4A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#18637 & #19309
Test Plan
Check Android
ReactImagePropertyTesttests pass.Related PRs
Release Notes
[ANDROID] [BUGFIX] [Unit Tests] - Fix ReactImagePropertyTest SoLoader failure