Uh oh!
There was an error while loading. Please reload this page.
add google maven repo in android project template - #19712
Conversation
| } | ||
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:2.2.3' |
There was a problem hiding this comment.
Are you sure this won't need to be updated to classpath 'com.android.tools.build:gradle:3.1.3'?
There was a problem hiding this comment.
Which I guess would require this change too: software-mansion/react-native-svg#584 (comment)
There was a problem hiding this comment.
But I'm not entirely sure, so yeah just asking
There was a problem hiding this comment.
This patch just works for me, you need to add the changes to android/build.gradle file in the root of your project. Please double check
Bumping gradle plugin to 3.x will cause many issues, like requires build-tools 27
There was a problem hiding this comment.
awesome, thanks for clarifying, as soon as we have a new RC out I'll test and report back :)
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This PR will add Google maven repo to RN project template that contains com.android.support:appcompat-v7:26.1.0, thus fixes `react-native run-android` using version 0.56.0-rc.1 CI is Green - https://circleci.com/gh/dulmandakh/react-native/235 new Android projects will build and run just fine. Closes#19712 Differential Revision: D8433730 Pulled By: hramos fbshipit-source-id: b7d5a1cd5a97b1c4aad2a307158d6dbfcf9a42a5
Summary: This PR will add Google maven repo to RN project template that contains com.android.support:appcompat-v7:26.1.0, thus fixes `react-native run-android` using version 0.56.0-rc.1 CI is Green - https://circleci.com/gh/dulmandakh/react-native/235 new Android projects will build and run just fine. Closesreact/react-native#19712 Differential Revision: D8433730 Pulled By: hramos fbshipit-source-id: b7d5a1cd5a97b1c4aad2a307158d6dbfcf9a42a5
This PR will add Google maven repo to RN project template that contains com.android.support:appcompat-v7:26.1.0, thus fixes
react-native run-androidusing version 0.56.0-rc.1CI is Green - https://circleci.com/gh/dulmandakh/react-native/235
Test Plan
new Android projects will build and run just fine.