Uh oh!
There was an error while loading. Please reload this page.
bump NDK toolchain to 4.9 - #19945
Conversation
dulmandakh
commented
Jun 28, 2018
hramos
commented
Jun 28, 2018
Also cc @fkgozali |
dulmandakh
commented
Jul 15, 2018
@fkgozali please review and merge |
dulmandakh
commented
Jul 15, 2018
Or maybe #19893, which does the same but also bumps NDK version. I tried every NDK version, and r14b was the latest version to compile with minimal code changes. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
dulmandakh
commented
Jul 23, 2018
@hramos is there any issue regarding merging this PR? I was able to compile RN with latest NDK, and would like to create a PR once this merged. |
hramos
commented
Jul 23, 2018
@dulmandakh No, no issues. We try to avoid landing diffs late on Friday afternoons. I'll get this going today. |
react-native-bot
commented
Jul 23, 2018
This pull request was closed by @dulmandakh in ccdd450. Once this commit is added to a release, you will see the corresponding version tag below the description at ccdd450. If the commit has a single |
This PR will bump NDK_TOOLCHAIN_VERSION to 4.9 or use GCC 4.9 to build C++ code. Once merged, we can bump folly to a newer version, which requires GCC 4.9.
Test Plan:
Everything build and run as usual.
Release Notes:
[ANDROID] [ENHANCEMENT] [NDK] - bump NDK_TOOLCHAIN_VERSION to 4.9