Uh oh!
There was an error while loading. Please reload this page.
add @NonNull, @Nullable annotations to native interfaces, classes - #19973
add @NonNull, @Nullable annotations to native interfaces, classes#19973dulmandakh wants to merge 6 commits into
Conversation
| dependencies { | ||
| compile fileTree(dir: "libs", include: ["*.jar"]) | ||
| compile "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}" | ||
| compile "com.android.support:support-annotations:${rootProject.ext.supportLibVersion}" |
There was a problem hiding this comment.
I think add this dependency to template is unnecessary.
dulmandakh
commented
Jun 29, 2018
@gengjiawen thank for the suggestion 👍 |
gengjiawen
commented
Jun 29, 2018
:) |
patrickkempff
commented
Jul 1, 2018
@dulmandakh & @gengjiawen thank you both for all the android improvements lately! |
janicduplessis
left a comment
There was a problem hiding this comment.
We don't really use the @nonnull annotation through the code base but I assume this is needed for better kotlin support? Seems fine to me.
| dependencies { | ||
| compile fileTree(dir: 'libs', include: ['*.jar']) | ||
| compile 'com.android.support:appcompat-v7:26.1.0' | ||
| compile 'com.android.support:support-annotations:26.1.0' |
There was a problem hiding this comment.
it's redundant, I'll remove it tomorrow
@janicduplessis yep, nullable and nonnull annotations are for Kotlin support, so that Android Studio knows if a value is nullable or not. |
janicduplessis
commented
Jul 16, 2018
Alright, I removed the extra dep. Thanks for working on this! @facebook-github-bot shipit |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
dulmandakh
commented
Jul 16, 2018
@janicduplessis thank you. Could you please review #19950 |
dulmandakh
commented
Jul 31, 2018
@hramos please review and merge. This will improve development experience of native module using Kotlin. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
commented
Aug 17, 2018
This one also saw some internal test failures, but they might be unrelated. Rerunning, will check again in a few hours. |
dulmandakh
commented
Aug 24, 2018
@hramos any updates? Maybe you need to add react_native_dep("third-party/android/support-annotations:android-support-annotations") as a dependency? |
This PR adds null annotations to interfaces and classes used to write native modules, that would make linting easier especially for Kotlin developers.
Test Plan:
Everything will build and run as usual.