Skip to content

Bump Android NDK to r17b - #20357

Closed
dulmandakh wants to merge 6 commits into
react:masterfrom
dulmandakh:bump-ndk-r17b
Closed

Bump Android NDK to r17b#20357
dulmandakh wants to merge 6 commits into
react:masterfrom
dulmandakh:bump-ndk-r17b

Conversation

@dulmandakh

@dulmandakhdulmandakh commented Jul 24, 2018

Copy link
Copy Markdown
Contributor

This PR bumps Android NDK version to r17b (latest). Cleaned up redundant LOCAL_EXPORT_CPPFLAGS rules in .mk files

Test Plan:

Everything compiles and runs as usual

Release Notes:

[ANDROID] [ENHANCEMENT] [NDK] - Bump to r17b version

@dulmandakhdulmandakh changed the title Bump ndk r17bBump Android NDK to r17bJul 24, 2018
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2018
@dulmandakhdulmandakh mentioned this pull request Jul 24, 2018
Closed
@dulmandakh
dulmandakh requested review from gengjiawen, hramos and janicduplessis and removed request for gengjiawenJuly 24, 2018 11:50
@gengjiawen

gengjiawen commented Jul 24, 2018

Copy link
Copy Markdown
Contributor

Thanks for the job, nicely done. Let's wait the ci fixed on master and then merge this.

gengjiawen
gengjiawen approved these changes Jul 24, 2018
View reviewed changes

@gengjiawengengjiawen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dulmandakh

dulmandakh commented Jul 24, 2018 via email

Copy link
Copy Markdown
ContributorAuthor

@dulmandakh

dulmandakh commented Jul 25, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Done and CI is green 😄 (https://circleci.com/gh/dulmandakh/react-native/954). Had to bump buck because it was trying to use removed ABI from NDK, and buck v2018.07.09.01 fixed it with facebook/buck@4ef8e96.

@dulmandakh

dulmandakh commented Jul 25, 2018

Copy link
Copy Markdown
ContributorAuthor

@hramos please review and merge

@dulmandakh

dulmandakh commented Jul 27, 2018

Copy link
Copy Markdown
ContributorAuthor

I would like to note that RNTester app works as usual. And I found that LOCAL_EXPORT_CPPFLAGS exports CFLAGS to including module, which resulted in polluted and mixed CFLAGS.

This was referenced Jul 28, 2018
Closed
Closed
@fungilation

fungilation commented Jul 28, 2018

Copy link
Copy Markdown

Awesome PR! 2 birds with 1 stone.

@dulmandakh

dulmandakh commented Jul 29, 2018

Copy link
Copy Markdown
ContributorAuthor

@fkgozali please review and merge. RNTester app works just fine.

@dulmandakhdulmandakh mentioned this pull request Jul 29, 2018
Closed
@facebook-github-botfacebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jul 30, 2018
facebook-github-bot
facebook-github-bot approved these changes Jul 30, 2018
View reviewed changes

@facebook-github-botfacebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

react-native-bot commented Jul 30, 2018

Copy link
Copy Markdown
Collaborator

This pull request was closed by @dulmandakh in 6117a6c.

Once this commit is added to a release, you will see the corresponding version tag below the description at 6117a6c. If the commit has a single master tag, it is not yet part of a release.

@reactreact locked as resolved and limited conversation to collaborators Jul 30, 2018
@react-native-botreact-native-bot added the Merged This PR has been merged. label Jul 30, 2018
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Aug 17, 2018
@dulmandakh@facebook-github-bot
Bump Android NDK to r17b (#20357)
7e7d88c
Summary:
This PR bumps Android NDK version to r17b (latest). Cleaned up redundant **LOCAL_EXPORT_CPPFLAGS** rules in .mk files
Pull Request resolved: react/react-native#20357
Differential Revision: D9068424
Pulled By: hramos
fbshipit-source-id: 8578637e38e807288b819a36cb75ea9feefcc09f
@dulmandakh
dulmandakh deleted the bump-ndk-r17b branch August 22, 2018 03:14
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
@dulmandakh@facebook-github-bot
Bump Android NDK to r17b (#20357)
53eea1b
Summary:
This PR bumps Android NDK version to r17b (latest). Cleaned up redundant **LOCAL_EXPORT_CPPFLAGS** rules in .mk files
Pull Request resolved: react/react-native#20357
Differential Revision: D9068424
Pulled By: hramos
fbshipit-source-id: 8578637e38e807288b819a36cb75ea9feefcc09f
@hramoshramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
@facebook-github-botfacebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hramoshramosAwaiting requested review from hramos
@janicduplessisjanicduplessisAwaiting requested review from janicduplessis
2 more reviewers
@gengjiawengengjiawengengjiawen approved these changes
@facebook-github-botfacebook-github-botfacebook-github-bot approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.Platform: AndroidAndroid applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dulmandakh@gengjiawen@fungilation@react-native-bot@facebook-github-bot@hramos