Uh oh!
There was an error while loading. Please reload this page.
[CI] Disable failing tests - #20622
Closed
hramos wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
approved these changes
Aug 10, 2018
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
commented
Aug 10, 2018
Collaborator
This pull request was closed by @hramos in e0465bf. Once this commit is added to a release, you will see the corresponding version tag below the description at e0465bf. If the commit has a single |
kelset pushed a commit
that referenced
this pull request
Aug 13, 2018
Summary: `test_detox_end_to_end` and `test_objc_end_to_end` are both failing on master. This is polluting internal diffs that do not introduce failures. As we just now started tracking Circle CI on our internal builds, I want to make sure we only nag internal diffs when the failure can actually be attributed to the diff. The failures in the e2e tests precede the Circle CI integration and are adding unnecessary noise. Going forward, we will immediately go back to a diff and push the author to fix the broken CI, so this PR is a temporary fix. Pull Request resolved: #20622 Differential Revision: D9272360 Pulled By: hramos fbshipit-source-id: 2f8d22e35d301aa7eb67ed08f6deed21bf971acd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_detox_end_to_endandtest_objc_end_to_endare both failing on master. This is polluting internal diffs that do not introduce failures.As we just now started tracking Circle CI on our internal builds, I want to make sure we only nag internal diffs when the failure can actually be attributed to the diff. The failures in the e2e tests precede the Circle CI integration and are adding unnecessary noise.
Going forward, we will immediately go back to a diff and push the author to fix the broken CI, so this PR is a temporary fix.