Skip to content

Fix #20991 - use name from app.json if available#20992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mike-marcacci wants to merge 1 commit into from
Closed

Fix #20991 - use name from app.json if available #20992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion react-native-git-upgrade/cliEntry.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,10 +114,18 @@ function readPackageFiles(useYarn) {
'package.json',
);
const pakPath = path.resolve(process.cwd(), 'package.json');
const appPath = path.resolve(process.cwd(), 'app.json');
let app = null;
try {
app = parseJsonFile(appPath);
} catch (err) {
log.warn('Unable to parse app.json', err.message);
}
return {
reactNativeNodeModulesPak: parseJsonFile(reactNativeNodeModulesPakPath),
reactNodeModulesPak: parseJsonFile(reactNodeModulesPakPath),
pak: parseJsonFile(pakPath),
app: app,
};
}

Expand DownExpand Up@@ -306,8 +314,9 @@ async function run(requestedVersion, cliArgs) {
reactNativeNodeModulesPak,
reactNodeModulesPak,
pak,
app,
} = readPackageFiles(useYarn);
const appName = pak.name;
const appName = (app && app.name) || pak.name;
const currentVersion = reactNativeNodeModulesPak.version;
const currentReactVersion = reactNodeModulesPak.version;
const declaredVersion = pak.dependencies['react-native'];
Expand Down