Uh oh!
There was an error while loading. Please reload this page.
StatusBar: Remove PropTypes - #21293
Conversation
| type DefaultProps = { | ||
| animated: boolean, | ||
| }; | ||
| type StatusBarProps = $ReadOnly<{| |
There was a problem hiding this comment.
I think I'd prefer if you just named these types Props. I believe that is consistent with all the other files
| * The background color of the status bar. | ||
| * @platform android | ||
| */ | ||
| backgroundColor?: ?string, |
There was a problem hiding this comment.
When there are a bunch of Props that are supported on different platforms, I like doing this pattern:
type AndroidProps = //
type IOSProps = //
type Props = $ReadOnly<{|
...IOSProps,
...AndroidProps,
// shared props
|}>
There was a problem hiding this comment.
And also re-organized these
facebook-github-bot
left a comment
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
commented
Sep 24, 2018
@empyrical merged commit cd1d3ce into Once this commit is added to a release, you will see the corresponding version tag below the description at cd1d3ce. If the commit has a single |
Summary: Part of: react-native-community/discussions-and-proposals#29 This PR removes the remaining PropTypes from `StatusBar` and moves its flowtypes to its own definition. Pull Request resolved: react#21293 Differential Revision: D10012963 Pulled By: TheSavior fbshipit-source-id: 7fb4e416eb49e7860809a3e2aaf157590908687d
Part of: react-native-community/discussions-and-proposals#29
This PR removes the remaining PropTypes from
StatusBarand moves its flowtypes to its own definition.Test Plan:
flow checkpasses for android and ios.Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/Components/StatusBar/StatusBar.js] - Removed PropTypes