Uh oh!
There was an error while loading. Please reload this page.
Fixes #issue18098 SectionList scrollToLocation - #21577
Conversation
facebook-github-bot
commented
Oct 8, 2018
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Oct 8, 2018
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
cpojer
commented
Jan 22, 2019
Thank you for this PR. |
d3cf10c to
3e82f11Compare
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.flowfound some issues.
| sectionIndex: number, | ||
| viewPosition?: number, | ||
| }) { | ||
| let index = params.itemIndex + 1; |
There was a problem hiding this comment.
prettier/prettier: Replace ?·params.itemIndex with ·?·params.itemIndex·
| sectionIndex: number, | ||
| viewPosition?: number, | ||
| }) { | ||
| let index = params.itemIndex + 1; |
There was a problem hiding this comment.
space-infix-ops: Infix operators must be spaced.
| 'use strict'; | ||
| const React = require('React'); | ||
| const Platform = require('../Utilities/Platform'); |
There was a problem hiding this comment.
Cannot resolve module ../Utilities/Platform.
pull-bot
commented
Jan 22, 2019
Generated by 🚫 dangerJS |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cpojer
commented
Jan 22, 2019
This PR is causing some headaches for some reason. I'm trying some git magic to put it all back together on top of master to be able to land it. |
Fixes#18098
Test Plan:
Scrolling to the last section android
Scrolling to the last section ios
Scrolling to the section index 1, item index 0 android
Scrolling to the section index 1, item index 0 ios
Release Notes:
Changelog:
[IOS] [BUGFIX] [VirtualizedSectionList.js] - Changed indexing depending on platform to fix overscrolling.